* [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
@ 2011-02-23 20:20 Gerhard Wiesinger
2011-03-01 19:20 ` Gerhard Wiesinger
0 siblings, 1 reply; 7+ messages in thread
From: Gerhard Wiesinger @ 2011-02-23 20:20 UTC (permalink / raw)
To: qemu-devel
bugfix under DOS for AMD netware driver:
AMD PCNTNW Ethernet MLID v3.10 (960115), network card not found
bugfix works well under DOS with:
1.) AMD NDIS driver v2.0.1
2.) AMD PCNTNW Ethernet MLID v3.10 (960115)
3.) Knoppix 6.2
---
hw/pcnet.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/hw/pcnet.c b/hw/pcnet.c
index db52dc5..6dfdcc4 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1562,8 +1562,24 @@ void pcnet_h_reset(void *opaque)
/* Initialize the PROM */
+ /*
+ Datasheet: http://pdfdata.datasheetsite.com/web/24528/AM79C970A.pdf
+ page 95
+ */
memcpy(s->prom, s->conf.macaddr.a, 6);
+ /* Reserved Location: must be 00h */
+ s->prom[6] = s->prom[7] = 0x00;
+ /* Reserved Location: must be 00h */
+ s->prom[8] = 0x00;
+ /* Hardware ID: must be 11h if compatibility to AMD drivers is desired */
+ s->prom[9] = 0x11;
+ /* User programmable space, init with 0 */
+ s->prom[10] = s->prom[11] = 0x00;
+ /* LSByte of two-byte checksum, which is the sum of bytes 00h-0Bh
+ and bytes 0Eh and 0Fh, must therefore be initialized with 0! */
s->prom[12] = s->prom[13] = 0x00;
+ /* Must be ASCII W (57h) if compatibility to AMD
+ driver software is desired */
s->prom[14] = s->prom[15] = 0x57;
for (i = 0,checksum = 0; i < 16; i++)
--
1.7.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
2011-02-23 20:20 Gerhard Wiesinger
@ 2011-03-01 19:20 ` Gerhard Wiesinger
2011-03-05 12:13 ` Blue Swirl
0 siblings, 1 reply; 7+ messages in thread
From: Gerhard Wiesinger @ 2011-03-01 19:20 UTC (permalink / raw)
To: qemu-devel
Hello,
Any feedback to the patch, ready to commit?
Thnx.
Ciao,
Gerhard
--
http://www.wiesinger.com/
On Wed, 23 Feb 2011, Gerhard Wiesinger wrote:
> bugfix under DOS for AMD netware driver:
> AMD PCNTNW Ethernet MLID v3.10 (960115), network card not found
>
> bugfix works well under DOS with:
> 1.) AMD NDIS driver v2.0.1
> 2.) AMD PCNTNW Ethernet MLID v3.10 (960115)
> 3.) Knoppix 6.2
> ---
> hw/pcnet.c | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index db52dc5..6dfdcc4 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1562,8 +1562,24 @@ void pcnet_h_reset(void *opaque)
>
> /* Initialize the PROM */
>
> + /*
> + Datasheet: http://pdfdata.datasheetsite.com/web/24528/AM79C970A.pdf
> + page 95
> + */
> memcpy(s->prom, s->conf.macaddr.a, 6);
> + /* Reserved Location: must be 00h */
> + s->prom[6] = s->prom[7] = 0x00;
> + /* Reserved Location: must be 00h */
> + s->prom[8] = 0x00;
> + /* Hardware ID: must be 11h if compatibility to AMD drivers is desired
> */
> + s->prom[9] = 0x11;
> + /* User programmable space, init with 0 */
> + s->prom[10] = s->prom[11] = 0x00;
> + /* LSByte of two-byte checksum, which is the sum of bytes 00h-0Bh
> + and bytes 0Eh and 0Fh, must therefore be initialized with 0! */
> s->prom[12] = s->prom[13] = 0x00;
> + /* Must be ASCII W (57h) if compatibility to AMD
> + driver software is desired */
> s->prom[14] = s->prom[15] = 0x57;
>
> for (i = 0,checksum = 0; i < 16; i++)
> --
> 1.7.3.4
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
2011-03-01 19:20 ` Gerhard Wiesinger
@ 2011-03-05 12:13 ` Blue Swirl
2011-03-05 12:45 ` Gerhard Wiesinger
0 siblings, 1 reply; 7+ messages in thread
From: Blue Swirl @ 2011-03-05 12:13 UTC (permalink / raw)
To: Gerhard Wiesinger; +Cc: qemu-devel
On Tue, Mar 1, 2011 at 9:20 PM, Gerhard Wiesinger <lists@wiesinger.com> wrote:
> Hello,
>
> Any feedback to the patch, ready to commit?
ERROR: Missing Signed-off-by: line(s)
Please add Signed-off-by: line.
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
@ 2011-03-05 12:44 Gerhard Wiesinger
2011-03-05 13:25 ` Blue Swirl
0 siblings, 1 reply; 7+ messages in thread
From: Gerhard Wiesinger @ 2011-03-05 12:44 UTC (permalink / raw)
To: qemu-devel
bugfix under DOS for AMD netware driver:
AMD PCNTNW Ethernet MLID v3.10 (960115), network card not found
bugfix works well under DOS with:
1.) AMD NDIS driver v2.0.1
2.) AMD PCNTNW Ethernet MLID v3.10 (960115)
3.) Knoppix 6.2
Signed-off-by: Gerhard Wiesinger <lists@wiesinger.com>
---
hw/pcnet.c | 16 ++++++++++++++++
1 files changed, 16 insertions(+), 0 deletions(-)
diff --git a/hw/pcnet.c b/hw/pcnet.c
index db52dc5..6dfdcc4 100644
--- a/hw/pcnet.c
+++ b/hw/pcnet.c
@@ -1562,8 +1562,24 @@ void pcnet_h_reset(void *opaque)
/* Initialize the PROM */
+ /*
+ Datasheet: http://pdfdata.datasheetsite.com/web/24528/AM79C970A.pdf
+ page 95
+ */
memcpy(s->prom, s->conf.macaddr.a, 6);
+ /* Reserved Location: must be 00h */
+ s->prom[6] = s->prom[7] = 0x00;
+ /* Reserved Location: must be 00h */
+ s->prom[8] = 0x00;
+ /* Hardware ID: must be 11h if compatibility to AMD drivers is desired */
+ s->prom[9] = 0x11;
+ /* User programmable space, init with 0 */
+ s->prom[10] = s->prom[11] = 0x00;
+ /* LSByte of two-byte checksum, which is the sum of bytes 00h-0Bh
+ and bytes 0Eh and 0Fh, must therefore be initialized with 0! */
s->prom[12] = s->prom[13] = 0x00;
+ /* Must be ASCII W (57h) if compatibility to AMD
+ driver software is desired */
s->prom[14] = s->prom[15] = 0x57;
for (i = 0,checksum = 0; i < 16; i++)
--
1.7.3.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
2011-03-05 12:13 ` Blue Swirl
@ 2011-03-05 12:45 ` Gerhard Wiesinger
0 siblings, 0 replies; 7+ messages in thread
From: Gerhard Wiesinger @ 2011-03-05 12:45 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
On Sat, 5 Mar 2011, Blue Swirl wrote:
> On Tue, Mar 1, 2011 at 9:20 PM, Gerhard Wiesinger <lists@wiesinger.com> wrote:
>> Hello,
>>
>> Any feedback to the patch, ready to commit?
>
> ERROR: Missing Signed-off-by: line(s)
>
> Please add Signed-off-by: line.
Resend.
Ciao,
Gerhard
--
http://www.wiesinger.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
2011-03-05 12:44 [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers Gerhard Wiesinger
@ 2011-03-05 13:25 ` Blue Swirl
2011-03-05 13:41 ` Gerhard Wiesinger
0 siblings, 1 reply; 7+ messages in thread
From: Blue Swirl @ 2011-03-05 13:25 UTC (permalink / raw)
To: Gerhard Wiesinger; +Cc: qemu-devel
Thanks, applied.
There were still some white space problem with the patch, the
unchanged lines had shifted by one space.
On Sat, Mar 5, 2011 at 2:44 PM, Gerhard Wiesinger <lists@wiesinger.com> wrote:
> bugfix under DOS for AMD netware driver:
> AMD PCNTNW Ethernet MLID v3.10 (960115), network card not found
>
> bugfix works well under DOS with:
> 1.) AMD NDIS driver v2.0.1
> 2.) AMD PCNTNW Ethernet MLID v3.10 (960115)
> 3.) Knoppix 6.2
>
> Signed-off-by: Gerhard Wiesinger <lists@wiesinger.com>
> ---
> hw/pcnet.c | 16 ++++++++++++++++
> 1 files changed, 16 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pcnet.c b/hw/pcnet.c
> index db52dc5..6dfdcc4 100644
> --- a/hw/pcnet.c
> +++ b/hw/pcnet.c
> @@ -1562,8 +1562,24 @@ void pcnet_h_reset(void *opaque)
>
> /* Initialize the PROM */
>
> + /*
> + Datasheet: http://pdfdata.datasheetsite.com/web/24528/AM79C970A.pdf
> + page 95
> + */
> memcpy(s->prom, s->conf.macaddr.a, 6);
> + /* Reserved Location: must be 00h */
> + s->prom[6] = s->prom[7] = 0x00;
> + /* Reserved Location: must be 00h */
> + s->prom[8] = 0x00;
> + /* Hardware ID: must be 11h if compatibility to AMD drivers is desired
> */
> + s->prom[9] = 0x11;
> + /* User programmable space, init with 0 */
> + s->prom[10] = s->prom[11] = 0x00;
> + /* LSByte of two-byte checksum, which is the sum of bytes 00h-0Bh
> + and bytes 0Eh and 0Fh, must therefore be initialized with 0! */
> s->prom[12] = s->prom[13] = 0x00;
> + /* Must be ASCII W (57h) if compatibility to AMD
> + driver software is desired */
> s->prom[14] = s->prom[15] = 0x57;
>
> for (i = 0,checksum = 0; i < 16; i++)
> --
> 1.7.3.4
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers
2011-03-05 13:25 ` Blue Swirl
@ 2011-03-05 13:41 ` Gerhard Wiesinger
0 siblings, 0 replies; 7+ messages in thread
From: Gerhard Wiesinger @ 2011-03-05 13:41 UTC (permalink / raw)
To: Blue Swirl; +Cc: qemu-devel
On Sat, 5 Mar 2011, Blue Swirl wrote:
> Thanks, applied.
>
> There were still some white space problem with the patch, the
> unchanged lines had shifted by one space.
I guess that comes from reading patch file into alpine and wrapping ...
Anyway, thnx.
Ciao,
Gehrard
--
http://www.wiesinger.com/
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2011-03-05 13:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-05 12:44 [Qemu-devel] [PATCH] hw/pcnet.c: Fix EPROM contents to suit AMD netware drivers Gerhard Wiesinger
2011-03-05 13:25 ` Blue Swirl
2011-03-05 13:41 ` Gerhard Wiesinger
-- strict thread matches above, loose matches on Subject: below --
2011-02-23 20:20 Gerhard Wiesinger
2011-03-01 19:20 ` Gerhard Wiesinger
2011-03-05 12:13 ` Blue Swirl
2011-03-05 12:45 ` Gerhard Wiesinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).