Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms

[Gerhard Wiesinger <lists@wiesinger.com>]

On Thu, 12 Jan 2012, Gerd Hoffmann wrote:

>  Hi,
>
>> I'm not sure about the consequences (hotplugging feature, etc.) when
>> changing it to romfile as in other PCI devices.
>
> There should be no noticable difference.

I don't know the consequences there so I think it is better to let that 
code and just fix the romfile issues.

>
>> Also the patch is more
>> generic and supports static and dynamic devices (hotplugable and
>> possible future devices).
>
> Hotplug works just fine for the other pci devices.
>
>> Patch supports without hotplugging both
>> options to disable the romfile:
>> ,romfile=
>> ,romfile=disabled
>
> That should be a separate patch.  And it should update
> pci_add_option_rom() so it works equally for all pci devices.

pci_add_option_rom() has been updated, so it is generic for all pci 
devices. Please look at the patch ...

>> And the patch has already been tested ...
>
> Well, it adds a bunch of code which would not be needed in the first
> place if you would simply make use of the romfile support of the pci layer.

As discussed it modifies romfile support on the pci layer ...

I reworked code for "disabled", "no" and "none" options, all these options 
work now.

Submitted new patch.

Ciao,
Gerhard

--
http://www.wiesinger.com/