From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43726)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1RqA5n-0003M6-NG
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 16:09:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1RqA5m-00029u-6A
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 16:09:19 -0500
Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:58988
	helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1RqA5l-00029n-M8
	for qemu-devel@nongnu.org; Wed, 25 Jan 2012 16:09:18 -0500
Date: Wed, 25 Jan 2012 22:08:10 +0100 (CET)
From: Gerhard Wiesinger <lists@wiesinger.com>
In-Reply-To: <4F0E92AF.6010001@redhat.com>
Message-ID: <alpine.LFD.2.02.1201252202570.9473@bbs.intern>
References: <alpine.LFD.2.02.1201081253310.14379@bbs.intern>
	<4F0AB023.5040705@redhat.com>
	<alpine.LFD.2.02.1201120741150.28218@bbs.intern>
	<4F0E92AF.6010001@redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC
 option roms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Kevin O'Connor <kevin@koconnor.net>, qemu-devel@nongnu.org, Gleb Natapov <gleb@redhat.com>

On Thu, 12 Jan 2012, Gerd Hoffmann wrote:

>  Hi,
>
>> I'm not sure about the consequences (hotplugging feature, etc.) when
>> changing it to romfile as in other PCI devices.
>
> There should be no noticable difference.

I don't know the consequences there so I think it is better to let that 
code and just fix the romfile issues.

>
>> Also the patch is more
>> generic and supports static and dynamic devices (hotplugable and
>> possible future devices).
>
> Hotplug works just fine for the other pci devices.
>
>> Patch supports without hotplugging both
>> options to disable the romfile:
>> ,romfile=
>> ,romfile=disabled
>
> That should be a separate patch.  And it should update
> pci_add_option_rom() so it works equally for all pci devices.

pci_add_option_rom() has been updated, so it is generic for all pci 
devices. Please look at the patch ...

>> And the patch has already been tested ...
>
> Well, it adds a bunch of code which would not be needed in the first
> place if you would simply make use of the romfile support of the pci layer.

As discussed it modifies romfile support on the pci layer ...

I reworked code for "disabled", "no" and "none" options, all these options 
work now.

Submitted new patch.

Ciao,
Gerhard

--
http://www.wiesinger.com/