From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54428) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqfin-0000QH-IE for qemu-devel@nongnu.org; Fri, 27 Jan 2012 01:55:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rqfil-0004lQ-HQ for qemu-devel@nongnu.org; Fri, 27 Jan 2012 01:55:41 -0500 Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:33310 helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rqfil-0004lM-5Z for qemu-devel@nongnu.org; Fri, 27 Jan 2012 01:55:39 -0500 Date: Fri, 27 Jan 2012 07:53:41 +0100 (CET) From: Gerhard Wiesinger In-Reply-To: <4F210E2F.5040706@suse.de> Message-ID: References: <4F210E2F.5040706@suse.de> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="-1463811584-1476429045-1327647222=:10836" Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Andreas_F=E4rber?= Cc: Jan Kiszka , qemu-devel@nongnu.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. ---1463811584-1476429045-1327647222=:10836 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-MIME-Autoconverted: from 8bit to quoted-printable by wiesinger.com id q0R6rgPW011488 On Thu, 26 Jan 2012, Andreas F=E4rber wrote: > Am 25.01.2012 21:04, schrieb Gerhard Wiesinger: >> Bugfix after reboot when vmmouse was enabled and another OS which uses >> e.g. PS/2 >> mouse. >> >> Details: >> When a guest activated the vmmouse followed by a reboot the vmmouse wa= s >> still >> enabled and the PS/2 mouse was therefore unsusable. When another guest >> is then >> booted without vmmouse support (e.g. PS/2 mouse) the mouse is not work= ing. >> >> Reason is that VMMouse has priority and disables all other mouse entit= ies >> and therefore must be disabled on reset. >> >> Testscenario: >> 1.) Boot e.g. OS with VMMouse support (e.g. Windows with VMMouse tools= ) >> 2.) reboot >> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) =3D> PS/2 mouse >> doesn't work >> any more. Fixes that issue. >> >> Testscenario 2 by Jan Kiszka : >> Confirm that this patch fixes a real issue. Setup: qemu.git, >> opensuse 11.4 guest, SDL graphic, system_reset while guest is using th= e >> vmmouse. Without the patch, the vmmouse become unusable after the >> reboot. Also, the mouse stays in absolute mode even before X starts ag= ain. >> >> Fixed by: >> Disabling the vmmouse in its reset handler. >> >> Signed-off-by: Gerhard Wiesinger > > I've been able to reproduce this the day before yesterday, on my versio= n > of qemu-kvm 0.15.1 with this patch apparently fixing the mouse after a > kdump. > > Yesterday however the reporter applied the patch himself to qemu.git an= d > reported this patch not to fix it on their side. > > We boot into the desktop, then do: > # echo 1 > /proc/sys/kernel/sysrq > # echo c > /proc/sysrq-trigger > System then reboots after a while and at login mouse does or does not w= ork. > > I had originally tried to kdump with just a virtio drive w/ default > settings; then I tried with the reporter's setting of -smp 4 (and > cache=3Dunsafe) and was able to reproduce it. Afterwards I was able to > reproduce without -smp 4 as well; no recompilation occurred. Guest was > the same SLES11 SP2 RC2 all the time. > > So, is there any indeterminism involved? I.e. is the mouse unusability > maybe not 100% reproducible? Anything else that may need to be fixed > beyond this patch? > > Patch does not break anything, so for now: > > Tested-by: Andreas F=E4rber All known issues I detected were fixed with the patch for me reproducable= =20 at least for now. Ciao, Gerhard -- http://www.wiesinger.com/ ---1463811584-1476429045-1327647222=:10836--