From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:54537)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1Rqfjr-0001DP-Kd
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 01:56:48 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1Rqfjq-0004pD-I1
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 01:56:47 -0500
Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:33348
	helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1Rqfjq-0004p9-7X
	for qemu-devel@nongnu.org; Fri, 27 Jan 2012 01:56:46 -0500
Date: Fri, 27 Jan 2012 07:56:04 +0100 (CET)
From: Gerhard Wiesinger <lists@wiesinger.com>
In-Reply-To: <m3fwf2buf5.fsf@blackfin.pond.sub.org>
Message-ID: <alpine.LFD.2.02.1201270754270.11665@bbs.intern>
References: <alpine.LFD.2.02.1201252200070.8940@bbs.intern>
	<m3ipjy29fw.fsf@blackfin.pond.sub.org>
	<4F212EC7.3010500@redhat.com>
	<m3fwf2buf5.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC
 option roms
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>, qemu-devel@nongnu.org

On Thu, 26 Jan 2012, Markus Armbruster wrote:

> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> On 01/26/12 08:45, Markus Armbruster wrote:
>>> Gerhard Wiesinger <lists@wiesinger.com> writes:
>>>
>>>> Option ROM for network interface cards (NICs) can now explicitly disabled
>>>> with romfile=disabled (or romfile=no or romfile=none) parameter.
>>>> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work.
>>>> This patch disables Option ROMs for iPXE for alls supported NICs
>>>> (hotplugable and non hotplugable).
>>>
>>> And now filenames "disabled", "no" and "none" don't work.
>>>
>>> Any way to fix "romfile="?
>>
>> Sure.
>
> This patch looks much better.  Gerhard does it solve your problem?
> Gerd, you might want to repost it in its own thread, as maintainers can
> easily miss patches buried deep in replies.

Patch looks good to me, it just initializes like all other devices.

But I still have to test it. Hopefully today in the evening or tomorrow.

Ciao,
Gerhard

--
http://www.wiesinger.com/