qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerhard Wiesinger <lists@wiesinger.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin O'Connor <kevin@koconnor.net>,
	Gerd Hoffmann <kraxel@redhat.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms
Date: Fri, 27 Jan 2012 17:02:40 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1201271658510.1944@bbs.intern> (raw)
In-Reply-To: <m3fwf2buf5.fsf@blackfin.pond.sub.org>

On Thu, 26 Jan 2012, Markus Armbruster wrote:

> Gerd Hoffmann <kraxel@redhat.com> writes:
>
>> On 01/26/12 08:45, Markus Armbruster wrote:
>>> Gerhard Wiesinger <lists@wiesinger.com> writes:
>>>
>>>> Option ROM for network interface cards (NICs) can now explicitly disabled
>>>> with romfile=disabled (or romfile=no or romfile=none) parameter.
>>>> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work.
>>>> This patch disables Option ROMs for iPXE for alls supported NICs
>>>> (hotplugable and non hotplugable).
>>>
>>> And now filenames "disabled", "no" and "none" don't work.
>>>
>>> Any way to fix "romfile="?
>>
>> Sure.
>
> This patch looks much better.  Gerhard does it solve your problem?
> Gerd, you might want to repost it in its own thread, as maintainers can
> easily miss patches buried deep in replies.

Can confirm this patch works well in all tried combinations.

3 Comments:
1.) NOK?: 2 NICs installed, no bootindex specified: Tries to boot only 
from one NIC, then from C: (one NIC has index first, second one has last 
index)
-boot order=nca,menu=on
-device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0 -net tap,ifname=tap0,script=no,downscript=no,vlan=0
  -device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1 -net tap,ifname=tap1,script=no,downscript=no,vlan=1
I would expect to try to boot from both NICs
1. iPXE (PCI 00:04:0)
...
8. iPXE (PCI 00:05:0)

2.) OK: 2 NICs installed, bootindex specified: Tries to boot from first 
and second NIC
-boot order=nca,menu=on
-device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,bootindex=1 -net tap,ifname=tap0,script=no,downscript=no,vlan=0
-device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,bootindex=2 -net tap,ifname=tap1,script=no,downscript=no,vlan=1
1. iPXE (PCI 00:04:0)
2. iPXE (PCI 00:05:0)
...

3.) NOK: 2 NICs installed, bootindex specified in reverse order: Tries to 
boot from 7e NIC and reboots ...
-boot order=nca,menu=on
-device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,bootindex=2 -net tap,ifname=tap0,script=no,downscript=no,vlan=0
-device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,bootindex=1 -net tap,ifname=tap1,script=no,downscript=no,vlan=1
1. iPXE (PCI 00:05:0)
2. iPXE (PCI 00:04:0)
...

Ciao,
Gerhard

--
http://www.wiesinger.com/

  parent reply	other threads:[~2012-01-27 16:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-25 21:01 [Qemu-devel] [PATCH] network: Added option to disable NIC option roms Gerhard Wiesinger
2012-01-26  7:45 ` Markus Armbruster
2012-01-26 10:45   ` Gerd Hoffmann
2012-01-26 11:00     ` Markus Armbruster
2012-01-27  6:56       ` Gerhard Wiesinger
2012-01-27 16:02       ` Gerhard Wiesinger [this message]
2012-02-13  6:23         ` Gerhard Wiesinger
2012-02-16  6:41           ` Gerhard Wiesinger
2012-02-01 22:19     ` Anthony Liguori
  -- strict thread matches above, loose matches on Subject: below --
2012-01-08 11:55 Gerhard Wiesinger
2012-01-08 16:40 ` Stefan Hajnoczi
2012-01-08 20:56   ` Gerhard Wiesinger
2012-01-09  8:06     ` Stefan Hajnoczi
2012-01-09  9:15 ` Gerd Hoffmann
2012-01-12  6:45   ` Gerhard Wiesinger
2012-01-12  7:58     ` Gerd Hoffmann
2012-01-25 21:08       ` Gerhard Wiesinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1201271658510.1944@bbs.intern \
    --to=lists@wiesinger.com \
    --cc=armbru@redhat.com \
    --cc=kevin@koconnor.net \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).