From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:46415) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqoIJ-0004ic-UY for qemu-devel@nongnu.org; Fri, 27 Jan 2012 11:05:01 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RqoID-0001qo-A4 for qemu-devel@nongnu.org; Fri, 27 Jan 2012 11:04:55 -0500 Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:59076 helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RqoIC-0001qa-VX for qemu-devel@nongnu.org; Fri, 27 Jan 2012 11:04:49 -0500 Date: Fri, 27 Jan 2012 17:02:40 +0100 (CET) From: Gerhard Wiesinger In-Reply-To: Message-ID: References: <4F212EC7.3010500@redhat.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH] network: Added option to disable NIC option roms List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Markus Armbruster Cc: Kevin O'Connor , Gerd Hoffmann , qemu-devel@nongnu.org On Thu, 26 Jan 2012, Markus Armbruster wrote: > Gerd Hoffmann writes: > >> On 01/26/12 08:45, Markus Armbruster wrote: >>> Gerhard Wiesinger writes: >>> >>>> Option ROM for network interface cards (NICs) can now explicitly disabled >>>> with romfile=disabled (or romfile=no or romfile=none) parameter. >>>> With hotplugable NICs (currently NE2000, PCNET) romfile=(empty) didn't work. >>>> This patch disables Option ROMs for iPXE for alls supported NICs >>>> (hotplugable and non hotplugable). >>> >>> And now filenames "disabled", "no" and "none" don't work. >>> >>> Any way to fix "romfile="? >> >> Sure. > > This patch looks much better. Gerhard does it solve your problem? > Gerd, you might want to repost it in its own thread, as maintainers can > easily miss patches buried deep in replies. Can confirm this patch works well in all tried combinations. 3 Comments: 1.) NOK?: 2 NICs installed, no bootindex specified: Tries to boot only from one NIC, then from C: (one NIC has index first, second one has last index) -boot order=nca,menu=on -device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0 -net tap,ifname=tap0,script=no,downscript=no,vlan=0 -device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1 -net tap,ifname=tap1,script=no,downscript=no,vlan=1 I would expect to try to boot from both NICs 1. iPXE (PCI 00:04:0) ... 8. iPXE (PCI 00:05:0) 2.) OK: 2 NICs installed, bootindex specified: Tries to boot from first and second NIC -boot order=nca,menu=on -device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,bootindex=1 -net tap,ifname=tap0,script=no,downscript=no,vlan=0 -device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,bootindex=2 -net tap,ifname=tap1,script=no,downscript=no,vlan=1 1. iPXE (PCI 00:04:0) 2. iPXE (PCI 00:05:0) ... 3.) NOK: 2 NICs installed, bootindex specified in reverse order: Tries to boot from 7e NIC and reboots ... -boot order=nca,menu=on -device rtl8139,mac=1a:46:0b:ca:bc:7c,vlan=0,bootindex=2 -net tap,ifname=tap0,script=no,downscript=no,vlan=0 -device pcnet,mac=1a:46:0b:ca:bc:7e,vlan=1,bootindex=1 -net tap,ifname=tap1,script=no,downscript=no,vlan=1 1. iPXE (PCI 00:05:0) 2. iPXE (PCI 00:04:0) ... Ciao, Gerhard -- http://www.wiesinger.com/