From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:51790) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtNPg-0006GO-Ih for qemu-devel@nongnu.org; Fri, 03 Feb 2012 12:59:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RtNPf-0000Vn-3f for qemu-devel@nongnu.org; Fri, 03 Feb 2012 12:59:08 -0500 Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:40168 helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RtNPe-0000IE-IW for qemu-devel@nongnu.org; Fri, 03 Feb 2012 12:59:07 -0500 Date: Fri, 3 Feb 2012 18:57:10 +0100 (CET) From: Gerhard Wiesinger In-Reply-To: <4F2C17AE.3040507@codemonkey.ws> Message-ID: References: <4F2C17AE.3040507@codemonkey.ws> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Subject: Re: [Qemu-devel] [PATCH] hw/vmmouse.c: Disable vmmouse after reboot List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org On Fri, 3 Feb 2012, Anthony Liguori wrote: > On 01/25/2012 02:04 PM, Gerhard Wiesinger wrote: >> Bugfix after reboot when vmmouse was enabled and another OS which uses e.g. >> PS/2 >> mouse. >> >> Details: >> When a guest activated the vmmouse followed by a reboot the vmmouse was >> still >> enabled and the PS/2 mouse was therefore unsusable. When another guest is >> then >> booted without vmmouse support (e.g. PS/2 mouse) the mouse is not working. >> >> Reason is that VMMouse has priority and disables all other mouse entities >> and therefore must be disabled on reset. >> >> Testscenario: >> 1.) Boot e.g. OS with VMMouse support (e.g. Windows with VMMouse tools) >> 2.) reboot >> 3.) Boot e.g. OS without VMMouse support (e.g. DOS) => PS/2 mouse doesn't >> work >> any more. Fixes that issue. >> >> Testscenario 2 by Jan Kiszka : >> Confirm that this patch fixes a real issue. Setup: qemu.git, >> opensuse 11.4 guest, SDL graphic, system_reset while guest is using the >> vmmouse. Without the patch, the vmmouse become unusable after the >> reboot. Also, the mouse stays in absolute mode even before X starts again. >> >> Fixed by: >> Disabling the vmmouse in its reset handler. >> >> Signed-off-by: Gerhard Wiesinger > > Applied. Thanks. > > Regards, > > Anthony Liguori Thanks. BTW: Why are always "signed offs" generated when a maintainer commits? e.g. 069ab0eb8a46bc4ff6f4d4d81bf037d3441347da Signed-off-by: Anthony Liguori Ciao, Gerhard -- http://www.wiesinger.com/