Re: [Qemu-devel] [PATCH][v11] megasas: LSI Megaraid SAS HBA emulation

[Gerhard Wiesinger <lists@wiesinger.com>]

On Fri, 17 Feb 2012, Hannes Reinecke wrote:

> On 02/17/2012 03:03 PM, Gerhard Wiesinger wrote:
>> Hello Hannes,
>>
>> Reason for my problems of non working megasas is that megasas.o was
>> no compiled:
>>
>> Details:
>> Makefile.objs
>> #hw-obj-$(CONFIG_MEGASAS_SCSI_PCI) += megasas.o
>> # OK:
>> hw-obj-y += megasas.o
>>
>> Although:
>> ./default-configs/pci.mak:CONFIG_MEGASAS_SCSI_PCI=y
>>
>> Did also a new configure run.
>>
>> Any ideas?
>>
>> Errors with the patch:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function
>> .megasas_init_firmware.:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:568:14: error:
>> variable .reply_queue_tail. set but not used
>> [-Werror=unused-but-set-variable]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:565:28: error:
>> variable .iq_pl. set but not used [-Werror=unused-but-set-variable]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function
>> .megasas_dcmd_ld_get_list.:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:995:32: error:
>> variable .max_ld_disks. set but not used
>> [-Werror=unused-but-set-variable]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function
>> .megasas_handle_dcmd.:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1203:17: error:
>> variable .size. set but not used [-Werror=unused-but-set-variable]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function
>> .megasas_xfer_complete.:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1386:14: error:
>> variable .bytes_left. set but not used
>> [-Werror=unused-but-set-variable]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c: In function
>> .megasas_handle_frame.:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1490:13: error:
>> variable .frame_cmd. set but not used [-Werror=unused-but-set-variable]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c: At top level:
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1872:1: error: data
>> definition has no type or storage class [-Werror]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1872:1: error: type
>> defaults to .int. in declaration of .type_init. [-Werror=implicit-int]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1872:1: error:
>> parameter names (without types) in function declaration [-Werror]
>> /root/download/qemu/git/qemu-kvm/hw/megasas.c:1867:13: error:
>> .megaraid1078_register_types. defined but not used
>> [-Werror=unused-function]
>> cc1: all warnings being treated as errors
>>
>> gcc --version
>> gcc (GCC) 4.6.2 20111027 (Red Hat 4.6.2-1)
>>
>> Please submit a new patch which removes unused variables, etc.
>>
>
> As already mentioned, this patch is against qemu.git, not qemu-kvm.git.
> The latter doesn't (yet) have the infrastructure changes, so
> obviously it won't compile there.
>
> For the unused variables I'll be updating the patch.

@Avi: Can you pull from qemu to test also qemu-kvm?

Thnx.

Ciao,
Gerhard

--
http://www.wiesinger.com/