qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerhard Wiesinger <lists@wiesinger.com>
To: Avi Kivity <avi@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>, Alexander Graf <agraf@suse.de>,
	Andreas Faerber <afaerber@suse.de>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH][v11] megasas: LSI Megaraid SAS HBA emulation
Date: Sat, 18 Feb 2012 12:15:31 +0100 (CET)	[thread overview]
Message-ID: <alpine.LFD.2.02.1202181213260.26683@bbs.intern> (raw)
In-Reply-To: <4F3F7936.8010700@redhat.com>

On Sat, 18 Feb 2012, Avi Kivity wrote:

> On 02/17/2012 07:11 PM, Gerhard Wiesinger wrote:
>>>> gcc --version
>>>> gcc (GCC) 4.6.2 20111027 (Red Hat 4.6.2-1)
>>>>
>>>> Please submit a new patch which removes unused variables, etc.
>>>>
>>>
>>> As already mentioned, this patch is against qemu.git, not qemu-kvm.git.
>>> The latter doesn't (yet) have the infrastructure changes, so
>>> obviously it won't compile there.
>>>
>>> For the unused variables I'll be updating the patch.
>>
>>
>> @Avi: Can you pull from qemu to test also qemu-kvm?
>>
>
> I pulled on Thursday, are you testing the latest?
>
> I something's missing, you can always do a local merge btw.

Yes, latest. With patch below, it works also on qemu-kvm.
So something is still missing ...

Local merge: But then history isn't the same ...
What command do you use?

Ciao,
Gerhard

--
http://www.wiesinger.com/

--- hw/megasas.c        2012-02-18 09:08:17.000000000 +0100
+++ ../qemu/hw/megasas.c        2012-02-17 20:27:23.000000000 +0100
@@ -1862,4 +1862,4 @@
      type_register_static(&megasas_info);
  }

-device_init(megaraid1078_register_types);
+type_init(megaraid1078_register_types);

  reply	other threads:[~2012-02-18 11:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-17  8:31 [Qemu-devel] [PATCH][v11] megasas: LSI Megaraid SAS HBA emulation Hannes Reinecke
2012-02-17 14:03 ` Gerhard Wiesinger
2012-02-17 14:15   ` Hannes Reinecke
2012-02-17 17:11     ` Gerhard Wiesinger
2012-02-18 10:11       ` Avi Kivity
2012-02-18 11:15         ` Gerhard Wiesinger [this message]
2012-02-18 11:53           ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.02.1202181213260.26683@bbs.intern \
    --to=lists@wiesinger.com \
    --cc=afaerber@suse.de \
    --cc=agraf@suse.de \
    --cc=avi@redhat.com \
    --cc=hare@suse.de \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).