From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:45281)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1RyiII-0002H8-Q5
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 06:17:36 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1RyiIH-0006dv-Gu
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 06:17:34 -0500
Received: from chello084112167138.7.11.vie.surfer.at ([84.112.167.138]:60135
	helo=wiesinger.com) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lists@wiesinger.com>) id 1RyiIH-0006dh-0q
	for qemu-devel@nongnu.org; Sat, 18 Feb 2012 06:17:33 -0500
Date: Sat, 18 Feb 2012 12:15:31 +0100 (CET)
From: Gerhard Wiesinger <lists@wiesinger.com>
In-Reply-To: <4F3F7936.8010700@redhat.com>
Message-ID: <alpine.LFD.2.02.1202181213260.26683@bbs.intern>
References: <1329467461-32083-1-git-send-email-hare@suse.de>
	<alpine.LFD.2.02.1202171459570.16501@bbs.intern>
	<4F3E60EA.4080801@suse.de>
	<alpine.LFD.2.02.1202171809500.17890@bbs.intern>
	<4F3F7936.8010700@redhat.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed
Subject: Re: [Qemu-devel] [PATCH][v11] megasas: LSI Megaraid SAS HBA
 emulation
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Avi Kivity <avi@redhat.com>
Cc: Hannes Reinecke <hare@suse.de>, Alexander Graf <agraf@suse.de>, Andreas Faerber <afaerber@suse.de>, qemu-devel@nongnu.org

On Sat, 18 Feb 2012, Avi Kivity wrote:

> On 02/17/2012 07:11 PM, Gerhard Wiesinger wrote:
>>>> gcc --version
>>>> gcc (GCC) 4.6.2 20111027 (Red Hat 4.6.2-1)
>>>>
>>>> Please submit a new patch which removes unused variables, etc.
>>>>
>>>
>>> As already mentioned, this patch is against qemu.git, not qemu-kvm.git.
>>> The latter doesn't (yet) have the infrastructure changes, so
>>> obviously it won't compile there.
>>>
>>> For the unused variables I'll be updating the patch.
>>
>>
>> @Avi: Can you pull from qemu to test also qemu-kvm?
>>
>
> I pulled on Thursday, are you testing the latest?
>
> I something's missing, you can always do a local merge btw.

Yes, latest. With patch below, it works also on qemu-kvm.
So something is still missing ...

Local merge: But then history isn't the same ...
What command do you use?

Ciao,
Gerhard

--
http://www.wiesinger.com/

--- hw/megasas.c        2012-02-18 09:08:17.000000000 +0100
+++ ../qemu/hw/megasas.c        2012-02-17 20:27:23.000000000 +0100
@@ -1862,4 +1862,4 @@
      type_register_static(&megasas_info);
  }

-device_init(megaraid1078_register_types);
+type_init(megaraid1078_register_types);