[Qemu-devel] Parameter parsing broken

[Qemu-devel] Parameter parsing broken

[Gerhard Wiesinger]

Hello,

Finally this commmit is no longer working:
commit 9ebe95fb606a8d6bebe29de3efc9b506c6428c62
Author: Gerd Hoffmann <kraxel@redhat.com>
Date:   Wed Feb 8 16:02:11 2012 +0100

     nic: zap obsolote romloading bits from ne2k + pcnet

     These days one just needs to specify the romfile in PCiDeviceInfo and
     everything magically works.  It also allows to disable pxe rom loading
     via "romfile=<emptystring>" like it is possible for all other nics.

     [ v2: rebased & adapted to qom changes ]

I bisected it down to an conincidence of the following commit:
acbac4a1dc974a3915760b4551336544c4360241 is the first bad commit
commit acbac4a1dc974a3915760b4551336544c4360241
Author: Paolo Bonzini <pbonzini@redhat.com>
Date:   Thu Feb 2 13:04:45 2012 +0100

     qdev: remove parse method for string properties

     We need the print method to put double quotes, but parsing is not special.

     Reviewed-by: Anthony Liguori <aliguori@us.ibm.com>
     Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

:040000 040000 f4761397afe09e200c9bcd77893d7f452148bf22 
b9ad8f8558e7e549fe89092ac87909f76bb54fc5 M      hw

Unfortunatly revertig the patch doesn't work since a lot of has been 
changed.

Relevant command line:
-device rtl8139,mac=00:02:44:92:87:6a,vlan=0,romfile=
-net tap,ifname=tap0,script=no,downscript=no,vlan=0

Problem I guessis  that empty strings are not allowed anymore in an option 
(romfile=) which is necessary.

So my inital, more complex patch, had its' qualification. :-)

Please fix it ASAP.

Ciao,
Gerhard

--
http://www.wiesinger.com/