From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:38927)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebott@linux.vnet.ibm.com>) id 1T1El7-0007xd-S8
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 06:54:03 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sebott@linux.vnet.ibm.com>) id 1T1El6-0000iG-KW
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 06:54:01 -0400
Received: from e06smtp18.uk.ibm.com ([195.75.94.114]:58618)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sebott@linux.vnet.ibm.com>) id 1T1El6-0000i5-BL
	for qemu-devel@nongnu.org; Tue, 14 Aug 2012 06:54:00 -0400
Received: from /spool/local
	by e06smtp18.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use
	Only! Violators will be prosecuted
	for <qemu-devel@nongnu.org> from <sebott@linux.vnet.ibm.com>;
	Tue, 14 Aug 2012 11:53:58 +0100
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[9.149.37.248])
	by b06cxnps4076.portsmouth.uk.ibm.com (8.13.8/8.13.8/NCO v10.0) with
	ESMTP id q7EArp5q17891498
	for <qemu-devel@nongnu.org>; Tue, 14 Aug 2012 10:53:51 GMT
Received: from d06av07.portsmouth.uk.ibm.com (d06av07.portsmouth.uk.ibm.com
	[127.0.0.1])
	by d06av07.portsmouth.uk.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with
	ESMTP id q7EAT88p020023
	for <qemu-devel@nongnu.org>; Tue, 14 Aug 2012 06:29:08 -0400
Date: Tue, 14 Aug 2012 12:53:56 +0200 (CEST)
From: Sebastian Ott <sebott@linux.vnet.ibm.com>
In-Reply-To: <20120814123821.1b6f93b7@BR9GNB5Z>
Message-ID: <alpine.LFD.2.02.1208141245270.1632@c4eb>
References: <1344351168-2568-1-git-send-email-cornelia.huck@de.ibm.com>
	<1344351168-2568-3-git-send-email-cornelia.huck@de.ibm.com>
	<alpine.LFD.2.02.1208141040240.1632@c4eb>
	<20120814123821.1b6f93b7@BR9GNB5Z>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH 2/4] s390: Add a mechanism to get the
	subchannel id.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: linux-s390 <linux-s390@vger.kernel.org>, Anthony Liguori <aliguori@us.ibm.com>, Rusty Russell <rusty@rustcorp.com.au>, KVM <kvm@vger.kernel.org>, Carsten Otte <cotte@de.ibm.com>, Marcelo Tosatti <mtosatti@redhat.com>, Heiko Carstens <heiko.carstens@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Alexander Graf <agraf@suse.de>, Christian Borntraeger <borntraeger@de.ibm.com>, Avi Kivity <avi@redhat.com>, Martin Schwidefsky <schwidefsky@de.ibm.com>


On Tue, 14 Aug 2012, Cornelia Huck wrote:
> Sebastian Ott <sebott@linux.vnet.ibm.com> wrote:
> > On Tue, 7 Aug 2012, Cornelia Huck wrote:
> > > +/**
> > > + * ccw_device_get_schid - obtain a subchannel id
> > > + * @cdev: device to obtain the id for
> > > + * @schid: where to fill in the values
> > > + */
> > > +void ccw_device_get_schid(struct ccw_device *cdev, struct subchannel_id *schid)
> > > +{
> > > +	*schid = cdev->private->schid;
> > > +}
> > > +EXPORT_SYMBOL(ccw_device_get_schid);
> > 
> > After I gave this some thought I like your version of this function
> > better. But please use the id of the parent subchannel instead of the
> > copy in cdev->private (since this will be removed soon). I'll do a
> > cleanup patch to convert the internal users of the old function to use
> > the one above.
> 
> Good, will change that (I think we can rely on a ccw device always
> having either a real subchannel or the orphanage pseudo subchannel as
> parent).

Yes you can rely on that.

> 
> Small taste question: EXPORT_SYMBOL vs EXPORT_SYMBOL_GPL?

get_subchannel_id was EXPORT_SYMBOL_GPL since its going to replace this
let's use the _GPL variant.

Regards,
Sebastian