From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Leon Alrae <leon.alrae@imgtec.com>,
QEMU Developers <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264
Date: Tue, 20 Jan 2015 18:16:18 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.11.1501201811480.28301@eddie.linux-mips.org> (raw)
In-Reply-To: <87lhkxiqak.fsf@blackfin.pond.sub.org>
On Tue, 20 Jan 2015, Markus Armbruster wrote:
> >> diff --git a/target-mips/translate.c b/target-mips/translate.c
> >> index e9d86b2..8abc12b 100644
> >> --- a/target-mips/translate.c
> >> +++ b/target-mips/translate.c
> >> @@ -18729,6 +18729,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext *ctx)
> >> case OPC_SWL:
> >> case OPC_SWR:
> >> check_insn_opc_removed(ctx, ISA_MIPS32R6);
> >> + /* fall through */
> >
> > Indent here seems to be out by one? The others look OK.
>
> Sorry about that. Fix up on commit, or would you like a respin?
It looks to me like this whole file requires reindentation, perhaps a
mechanical update like that would be better. There are many lines with 9
leading spaces (`wc -l' tells me 20), that I deliberately left as they are
with my recent patches in this area so as not to obfuscate semantic
changes. There may be some more issues.
Maciej
next prev parent reply other threads:[~2015-01-20 18:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 9:59 [Qemu-devel] [PATCH] target-mips: Clean up switch fall through after commit fecd264 Markus Armbruster
2015-01-20 11:05 ` Peter Maydell
2015-01-20 12:34 ` Markus Armbruster
2015-01-20 18:16 ` Maciej W. Rozycki [this message]
2015-01-20 18:35 ` Peter Maydell
2015-01-20 18:51 ` Maciej W. Rozycki
2015-01-21 7:39 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1501201811480.28301@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).