From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34415)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <macro@linux-mips.org>) id 1YDdLk-0007lz-85
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 13:16:25 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <macro@linux-mips.org>) id 1YDdLh-0004t7-Dg
	for qemu-devel@nongnu.org; Tue, 20 Jan 2015 13:16:24 -0500
Received: from localhost.localdomain ([127.0.0.1]:49370 "EHLO
	localhost.localdomain" rhost-flags-OK-OK-OK-OK)
	by eddie.linux-mips.org with ESMTP id S27011260AbbATSQSx3fs7 (ORCPT
	<rfc822;qemu-devel@nongnu.org> + 1 other);
	Tue, 20 Jan 2015 19:16:18 +0100
Date: Tue, 20 Jan 2015 18:16:18 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@linux-mips.org>
In-Reply-To: <87lhkxiqak.fsf@blackfin.pond.sub.org>
Message-ID: <alpine.LFD.2.11.1501201811480.28301@eddie.linux-mips.org>
References: <1421747963-2860-1-git-send-email-armbru@redhat.com>
	<CAFEAcA9Gw-q+NDvb-Ysj-uB=QRdK_1GQJJZUQ2sOjpeBMnGDwg@mail.gmail.com>
	<87lhkxiqak.fsf@blackfin.pond.sub.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH] target-mips: Clean up switch fall through
 after commit fecd264
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: QEMU Trivial <qemu-trivial@nongnu.org>, Peter Maydell <peter.maydell@linaro.org>, Leon Alrae <leon.alrae@imgtec.com>, QEMU Developers <qemu-devel@nongnu.org>, Aurelien Jarno <aurelien@aurel32.net>

On Tue, 20 Jan 2015, Markus Armbruster wrote:

> >> diff --git a/target-mips/translate.c b/target-mips/translate.c
> >> index e9d86b2..8abc12b 100644
> >> --- a/target-mips/translate.c
> >> +++ b/target-mips/translate.c
> >> @@ -18729,6 +18729,7 @@ static void decode_opc(CPUMIPSState *env, DisasContext *ctx)
> >>      case OPC_SWL:
> >>      case OPC_SWR:
> >>          check_insn_opc_removed(ctx, ISA_MIPS32R6);
> >> +         /* fall through */
> >
> > Indent here seems to be out by one? The others look OK.
> 
> Sorry about that.  Fix up on commit, or would you like a respin?

 It looks to me like this whole file requires reindentation, perhaps a 
mechanical update like that would be better.  There are many lines with 9 
leading spaces (`wc -l' tells me 20), that I deliberately left as they are 
with my recent patches in this area so as not to obfuscate semantic 
changes.  There may be some more issues.

  Maciej