From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45548)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <macro@linux-mips.org>) id 1YGGfr-0006ls-QV
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 19:40:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <macro@linux-mips.org>) id 1YGGfo-0001f7-Kq
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 19:40:03 -0500
Received: from eddie.linux-mips.org ([148.251.95.138]:52281
	helo=cvs.linux-mips.org) by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <macro@linux-mips.org>) id 1YGGfo-0001eg-Bv
	for qemu-devel@nongnu.org; Tue, 27 Jan 2015 19:40:00 -0500
Received: from localhost.localdomain ([127.0.0.1]:60746 "EHLO
	localhost.localdomain" rhost-flags-OK-OK-OK-OK)
	by eddie.linux-mips.org with ESMTP id S27009768AbbA1Aj6npwLJ (ORCPT
	<rfc822;qemu-devel@nongnu.org>); Wed, 28 Jan 2015 01:39:58 +0100
Date: Wed, 28 Jan 2015 00:39:58 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@linux-mips.org>
In-Reply-To: <1422288626-6595-1-git-send-email-leon.alrae@imgtec.com>
Message-ID: <alpine.LFD.2.11.1501280027470.28301@eddie.linux-mips.org>
References: <1422288626-6595-1-git-send-email-leon.alrae@imgtec.com>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH] target-mips: fix CP0.BadVAddr by stopping
 translation on Address error
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leon Alrae <leon.alrae@imgtec.com>
Cc: qemu-devel@nongnu.org, aurelien@aurel32.net

On Mon, 26 Jan 2015, Leon Alrae wrote:

> BadVAddr is supposed to capture the most recent address that caused
> the exception. Currently this is not happening as translation is not stopped
> and BadVAddr is updated with subsequent addresses.
> 
> Signed-off-by: Leon Alrae <leon.alrae@imgtec.com>
> ---

 I think this deserves a better description as it is about the specific 
case of an unaligned standard MIPS instruction fetch.  Address Error 
exceptions can also happen for other reasons: unaligned data accesses or 
any accesses outside memory segments the current execution mode is allowed 
to reach.

 While at it I think it may be worth double-checking if the other places 
that trigger this exception get it right.

  Maciej