From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Leon Alrae <leon.alrae@imgtec.com>
Cc: amit.shah@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org,
Aurelien Jarno <aurelien@aurel32.net>,
Richard Henderson <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState
Date: Fri, 20 Feb 2015 13:12:27 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.11.1502200212400.1995@eddie.linux-mips.org> (raw)
In-Reply-To: <54E612BD.1090607@imgtec.com>
On Thu, 19 Feb 2015, Leon Alrae wrote:
> > Surely these fp_status fields are simply implementation of the architectural
> > CSR registers?
> >
> > IMO you shouldn't store things related to TCG state, but always how the
> > architecture represents it. That way you're free to change the TCG
> > implementation without breaking save/restore.
>
> Good point. Saving fp_status and msa_fp_status doesn't seem to be needed
> at all as they can be restored from FCSR and MSACSR respectively.
Agreed. Richard, thanks for the suggestion!
Maciej
prev parent reply other threads:[~2015-02-20 13:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-18 14:51 [Qemu-devel] [PATCH 0/2] target-mips: port MIPS CPU to VMState Leon Alrae
2015-02-18 14:51 ` [Qemu-devel] [PATCH 1/2] target-mips: replace cpu_save/cpu_load with VMStateDescription Leon Alrae
2015-02-18 16:59 ` Andreas Färber
2015-02-19 10:23 ` Leon Alrae
2015-02-18 14:51 ` [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState Leon Alrae
2015-02-19 15:43 ` Richard Henderson
2015-02-19 16:43 ` Leon Alrae
2015-02-20 13:12 ` Maciej W. Rozycki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.11.1502200212400.1995@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=amit.shah@redhat.com \
--cc=aurelien@aurel32.net \
--cc=leon.alrae@imgtec.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).