From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOnNg-0001o1-Kt for qemu-devel@nongnu.org; Fri, 20 Feb 2015 08:12:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOnNc-0007Hx-62 for qemu-devel@nongnu.org; Fri, 20 Feb 2015 08:12:32 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:58450 helo=cvs.linux-mips.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOnNb-0007Hq-TV for qemu-devel@nongnu.org; Fri, 20 Feb 2015 08:12:28 -0500 Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S27006534AbbBTNM1EGopq (ORCPT ); Fri, 20 Feb 2015 14:12:27 +0100 Date: Fri, 20 Feb 2015 13:12:27 +0000 (GMT) Sender: "Maciej W. Rozycki" From: "Maciej W. Rozycki" In-Reply-To: <54E612BD.1090607@imgtec.com> Message-ID: References: <1424271115-7885-1-git-send-email-leon.alrae@imgtec.com> <1424271115-7885-3-git-send-email-leon.alrae@imgtec.com> <54E604AD.8070602@twiddle.net> <54E612BD.1090607@imgtec.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH 2/2] target-mips: add missing MSA and correct FP in VMState List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: amit.shah@redhat.com, quintela@redhat.com, qemu-devel@nongnu.org, Aurelien Jarno , Richard Henderson On Thu, 19 Feb 2015, Leon Alrae wrote: > > Surely these fp_status fields are simply implementation of the architectural > > CSR registers? > > > > IMO you shouldn't store things related to TCG state, but always how the > > architecture represents it. That way you're free to change the TCG > > implementation without breaking save/restore. > > Good point. Saving fp_status and msa_fp_status doesn't seem to be needed > at all as they can be restored from FCSR and MSACSR respectively. Agreed. Richard, thanks for the suggestion! Maciej