From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59454) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOnNH-0001Bh-Ji for qemu-devel@nongnu.org; Fri, 20 Feb 2015 08:12:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YOnNE-0007Db-Ba for qemu-devel@nongnu.org; Fri, 20 Feb 2015 08:12:07 -0500 Received: from eddie.linux-mips.org ([148.251.95.138]:58443 helo=cvs.linux-mips.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YOnNE-0007D3-2c for qemu-devel@nongnu.org; Fri, 20 Feb 2015 08:12:04 -0500 Received: (from localhost user: 'macro', uid#1010) by eddie.linux-mips.org with ESMTP id S27006534AbbBTNL5Eynj- convert rfc822-to-quoted-printable (ORCPT ); Fri, 20 Feb 2015 14:11:57 +0100 Date: Fri, 20 Feb 2015 13:11:57 +0000 (GMT) Sender: "Maciej W. Rozycki" From: "Maciej W. Rozycki" In-Reply-To: <54E5C9D0.6010700@imgtec.com> Message-ID: References: <1422288626-6595-1-git-send-email-leon.alrae@imgtec.com> <54E5C9D0.6010700@imgtec.com> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Subject: Re: [Qemu-devel] [PATCH] target-mips: fix CP0.BadVAddr by stopping translation on Address error List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Leon Alrae Cc: qemu-devel@nongnu.org, aurelien@aurel32.net On Thu, 19 Feb 2015, Leon Alrae wrote: > > I think this deserves a better description as it is about the spec= ific=20 > > case of an unaligned standard MIPS instruction fetch. Address Erro= r=20 > > exceptions can also happen for other reasons: unaligned data access= es or=20 > > any accesses outside memory segments the current execution mode is = allowed=20 > > to reach. >=20 > I believe that the one line change in the patch makes that clear. I > agree however that the description itself could be more precise. I agree the patch itself is clear, but someone reading the commit migh= t=20 infer this is the only place the Address Error exception happens. Also= =20 the patch itself does not show up in some places, e.g. `git log' where = -p=20 hasn't been also supplied, to complement information provided in the lo= g. > > While at it I think it may be worth double-checking if the other p= laces=20 > > that trigger this exception get it right. >=20 > Other places seem to look fine. Even decode_micromips_opc handles it > correctly whereas decode_opc -=E2=80=93 which obviously was implement= ed before > microMIPS -- never got fixed. Great that you checked, thanks! Maciej