From: P J P <ppandit@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Jason Wang <jasowang@redhat.com>,
QEMU Developer <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops
Date: Fri, 20 Nov 2015 16:57:53 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1511201647500.22982@wniryva> (raw)
In-Reply-To: <564EDF60.7080305@weilnetz.de>
+-- On Fri, 20 Nov 2015, Stefan Weil wrote --+
| include/hw/pci/pci.h: static inline uint##_bits##_t
| ld##_l##_pci_dma(PCIDevice *dev, \
I see.
| Is there an ideal count? If it is too low, it might break some use cases.
| If it is too high, it will take longer until the loop is finished.
-> https://url.corp.redhat.com/8255x-manual-pdf
I tried to look trough the 8255x manual above, it does not have a specific
value for the count, as it's a linked list of command blocks.
| I don't think EEPRO100 emulation is used in critical production
| applications. Therefore a lower value and a debug message when this value is
| exceeded might be helpful to find out which lowest value is acceptable. If
| you want to avoid this risk, the value should be set to 256, 10000, 65536 or
| any other higher value. Feel free to change this when you apply the patch.
I guess Jason would be best to decide that.
Thank you.
--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2015-11-20 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-20 7:42 [Qemu-devel] [PATCH for-2.5] eepro100: Prevent two endless loops Stefan Weil
2015-11-20 8:39 ` P J P
2015-11-20 8:52 ` Stefan Weil
2015-11-20 11:27 ` P J P [this message]
2015-11-25 3:08 ` Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1511201647500.22982@wniryva \
--to=ppandit@redhat.com \
--cc=jasowang@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).