From: P J P <ppandit@redhat.com>
To: Miao Yan <yanmiaobest@gmail.com>
Cc: Dmitry Fleytman <dmitry@daynix.com>,
Jason Wang <jasowang@redhat.com>, QEMU <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure
Date: Tue, 22 Dec 2015 14:36:22 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1512221423200.1424@wniryva> (raw)
In-Reply-To: <CAPc5xaPS+pmemPCJo7v=S3XMHy9HBZL_9U2w6E=UyxqLYOmefw@mail.gmail.com>
+-- On Tue, 22 Dec 2015, Miao Yan wrote --+
| > If '1' indicates the error, the 'default:' case in the same switch needs to be
| > updated too.
|
| '1' indicates an error on device activation. Not sure about the 'unknown
| command' case.
Ideally it should be same, inconsistent return codes wouldn't be helpful.
| Linux driver uses VXMNET3_READ_BAR1_REG() which calls readl().
| That should be an indication that the driver expects 32bit values.
Right.
| But the prototype in MemoryRegionOps requires uint64_t.
That is odd. It does not seem right to use uint64_t for 32bit values, and
then return a negative(-1) value.
@Dmitry...?
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2015-12-22 9:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-21 11:06 [Qemu-devel] [PATCH 0/3] correct some register return values for vxmnet3 Miao Yan
2015-12-21 11:06 ` [Qemu-devel] [PATCH 1/3] net/vmxnet3: return 1 on device activation failure Miao Yan
2015-12-21 18:15 ` P J P
2015-12-22 2:56 ` Miao Yan
2015-12-22 9:06 ` P J P [this message]
2015-12-22 9:26 ` Miao Yan
2015-12-22 9:33 ` Dmitry Fleytman
2015-12-21 11:06 ` [Qemu-devel] [PATCH 2/3] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DID_* command Miao Yan
2015-12-21 11:06 ` [Qemu-devel] [PATCH 3/3] net/vmxnet3: return correct value for VMXNET3_CMD_GET_DEV_EXTRA_INFO Miao Yan
2015-12-21 17:19 ` [Qemu-devel] [PATCH 0/3] correct some register return values for vxmnet3 Dmitry Fleytman
2015-12-22 2:44 ` Miao Yan
2015-12-22 7:05 ` Dmitry Fleytman
2015-12-23 2:15 ` Jason Wang
2015-12-23 3:12 ` Miao Yan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1512221423200.1424@wniryva \
--to=ppandit@redhat.com \
--cc=dmitry@daynix.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yanmiaobest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).