From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEbjL-0005Rh-V2 for qemu-devel@nongnu.org; Thu, 31 Dec 2015 06:49:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aEbjG-00039R-W0 for qemu-devel@nongnu.org; Thu, 31 Dec 2015 06:49:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:38562) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aEbjG-00039N-Qn for qemu-devel@nongnu.org; Thu, 31 Dec 2015 06:49:14 -0500 Date: Thu, 31 Dec 2015 17:19:06 +0530 (IST) From: P J P In-Reply-To: <5684D6AC.7030701@redhat.com> Message-ID: References: <1451537606-16030-1-git-send-email-ppandit@redhat.com> <5684BB0A.3080007@redhat.com> <5684D6AC.7030701@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATVH v2] net: ne2000: fix bounds check in ioport operations List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: QEMU Developers , Ling Liu +-- On Thu, 31 Dec 2015, Jason Wang wrote --+ | Btw, looking at ne2000_mem_writew(), it has: | addr &= ~1; Yes, this seems to ensure that write starts at an even address. | at the beginning, so looks like we are really safe, Need only to care | about writel? Right, I've sent an updated patch for the same. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F