From: P J P <ppandit@redhat.com>
To: Stefan Weil <sw@weilnetz.de>
Cc: Peter Maydell <peter.maydell@linaro.org>,
Qemu devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH for v2.3.0] fw_cfg: add check to validate current entry value
Date: Wed, 6 Jan 2016 11:51:58 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1601061149550.5260@wniryva> (raw)
In-Reply-To: <568C25EE.4040109@weilnetz.de>
+-- On Tue, 5 Jan 2016, Stefan Weil wrote --+
| > - s->cur_offset < e->len) {
| > + if (s->cur_entry != FW_CFG_INVALID
| > + && s->cur_entry & FW_CFG_WRITE_CHANNEL
| > + && e->callback
| > + && s->cur_offset < e->len) {
|
| I suggest to test e != NULL instead of s->cur_entry != FW_CFG_INVALID.
|
| Of course both variants are equivalent, but e != NULL might be easier
| to review and make work of static code analyzers easier, too.
Yes, I've sent a revised patch with this change.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-01-06 6:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 14:55 [Qemu-devel] [PATCH for v2.3.0] fw_cfg: add check to validate current entry value P J P
2016-01-05 14:55 ` P J P
2016-01-05 20:22 ` Stefan Weil
2016-01-06 6:21 ` P J P [this message]
2016-01-05 18:08 ` P J P
2016-01-06 1:43 ` 朱东海(启路)
2016-01-06 8:16 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1601061149550.5260@wniryva \
--to=ppandit@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).