From: P J P <ppandit@redhat.com>
To: Michal Privoznik <mprivozn@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms
Date: Thu, 7 Jan 2016 00:07:54 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1601062300140.501@wniryva> (raw)
In-Reply-To: <81110f82ab57277a4200d66da5c6d438f61aef93.1452076543.git.mprivozn@redhat.com>
+-- On Wed, 6 Jan 2016, Michal Privoznik wrote --+
| }
| - if (!blk_is_inserted(conf->conf.blk)) {
| +
| + dinfo = blk_legacy_dinfo(conf->conf.blk);
| + if (!((dinfo && dinfo->media_cd) ||
| + blk_is_inserted(conf->conf.blk))) {
| error_setg(errp, "Device needs media, but drive is empty");
| return;
| }
The if expression seems little confusing; Maybe
-> if (dinfo && !dinfo->media_cd && !blk_is_inserted(conf->conf.blk))
--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-01-06 18:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-06 10:35 [Qemu-devel] [PATCH] virtio-blk: Allow startup of empty cdroms Michal Privoznik
2016-01-06 18:37 ` P J P [this message]
2016-01-07 4:48 ` Stefan Hajnoczi
2016-01-07 6:42 ` Michal Privoznik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1601062300140.501@wniryva \
--to=ppandit@redhat.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).