From: P J P <ppandit@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: Qinghao Tang <luodalongde@gmail.com>,
qemu-devel@nongnu.org, qemu-block@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] ide: ahci: reset ncq object to unused on error
Date: Sat, 9 Jan 2016 00:46:57 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1601090040080.2778@wniryva> (raw)
In-Reply-To: <56900260.6030105@redhat.com>
+-- On Fri, 8 Jan 2016, John Snow wrote --+
| In both of these error pathways, AIOCB is actually never assigned to
| begin with.
True, it's mentioned in the commit message.
| So it's not necessarily a use-after-free.
Yes, right.
| I think it should be safe to put ncq_tfs->used = 0 directly inside of
| ncq_err, and that way we won't have any other error pathways omitting
| this in the future.
Okay, I'll send an updated patch.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-01-08 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 12:08 [Qemu-devel] [PATCH] ide: ahci: reset ncq object to unused on error P J P
2016-01-08 18:39 ` John Snow
2016-01-08 19:16 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1601090040080.2778@wniryva \
--to=ppandit@redhat.com \
--cc=jsnow@redhat.com \
--cc=luodalongde@gmail.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).