From: P J P <ppandit@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Qinghao Tang <luodalongde@gmail.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] sd: limit sd_cmd_type array index 'req.cmd'
Date: Thu, 21 Jan 2016 00:23:53 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1601210021320.1394@wniryva> (raw)
In-Reply-To: <CAFEAcA_6yCxNrQgfDZmmo_EcJR1eERLOCaFg4G9_juE8Ey6xug@mail.gmail.com>
+-- On Wed, 20 Jan 2016, Peter Maydell wrote --+
| This isn't the only bit of sd.c that assumes that the controller
| model hasn't passed it an oversize command number --
| sd_do_command() calls cmd_valid_while_locked() which uses req.cmd
| as an index into sd_cmd_class[].
Ah yes; I looked for 'req.cmd', but missed 'req->cmd'. I've sent a revised
patch v2.
Thank you.
--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-01-20 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 13:14 [Qemu-devel] [PATCH] sd: limit sd_cmd_type array index 'req.cmd' P J P
2016-01-20 14:00 ` Peter Maydell
2016-01-20 18:53 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1601210021320.1394@wniryva \
--to=ppandit@redhat.com \
--cc=luodalongde@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).