qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: P J P <ppandit@redhat.com>
To: yanghongke <yanghongke@huawei.com>
Cc: Jason Wang <jasowang@redhat.com>,
	QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] 答复: [PATCH] net: ne2000: check ring buffer control registers
Date: Tue, 9 Feb 2016 12:19:49 +0530 (IST)	[thread overview]
Message-ID: <alpine.LFD.2.20.1602091218120.31016@wniryva> (raw)
In-Reply-To: <FF590334B0339B429D9D096AF9CE3A202A3CBB71@szxeml523-mbs.china.huawei.com>

+-- On Fri, 5 Feb 2016, yanghongke wrote --+
| I think the important issue is that we should modify ne2000_receive
| 
| > @@ -247,6 +247,7ssize_t ne2000_receive(NetClientState *nc, const uint8_t *buf, size_t size_)
| > -	if (index <= s->stop)
| > +	if (index < s->stop)

  That'd break the loop, instead of resetting index to s->start, when index 
reaches s->stop.

--
 - P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F

  reply	other threads:[~2016-02-09  6:49 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-02 14:29 [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers P J P
2016-02-05  9:04 ` Jason Wang
2016-02-05  9:29   ` [Qemu-devel] 答复: " yanghongke
2016-02-09  6:49     ` P J P [this message]
2016-02-09  6:47   ` [Qemu-devel] " P J P
2016-02-15  4:25     ` P J P
2016-02-23  3:27     ` Jason Wang
2016-02-23  8:28       ` P J P
2016-02-24  1:52         ` Jason Wang
2016-02-24  5:58           ` P J P

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.LFD.2.20.1602091218120.31016@wniryva \
    --to=ppandit@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=yanghongke@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).