From: P J P <ppandit@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Yang Hongke <yanghongke@huawei.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers
Date: Mon, 15 Feb 2016 09:55:21 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1602150954001.976@wniryva> (raw)
In-Reply-To: <alpine.LFD.2.20.1602091152150.31016@wniryva>
+-- On Tue, 9 Feb 2016, P J P wrote --+
| +-- On Fri, 5 Feb 2016, Jason Wang wrote --+
| | I suspect this could even work. Consider after realizing, s->stop is
| | zero, any attempt to set STARTPG will fail?
|
| Ie after 'pci_ne2000_realize'? It does not seem to set or reset s->stop
| register.
|
| | This may not be sufficient, consider:
| |
| | set start to 1
| | set stop to 100
| | set boundary to 50
| | then set stop to 10
|
| I think any attempts to define the ring buffer limits should reset
| 'boundary' and 'curpag' registers to s->start(STARTPG). I wonder if a driver
| should be allowed to fiddle with the ring buffers location inside contorller's
| memory. It does not seem right.
|
| | I'm thinking maybe we need check during receiving like what we did in
| | dd793a74882477ca38d49e191110c17dfee51dcc?
|
| Check if (s->start == s->stop) at each receive call?
Ping...Jason?
--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-02-15 4:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 14:29 [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers P J P
2016-02-05 9:04 ` Jason Wang
2016-02-05 9:29 ` [Qemu-devel] 答复: " yanghongke
2016-02-09 6:49 ` P J P
2016-02-09 6:47 ` [Qemu-devel] " P J P
2016-02-15 4:25 ` P J P [this message]
2016-02-23 3:27 ` Jason Wang
2016-02-23 8:28 ` P J P
2016-02-24 1:52 ` Jason Wang
2016-02-24 5:58 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602150954001.976@wniryva \
--to=ppandit@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yanghongke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).