From: P J P <ppandit@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Qinghao Tang <luodalongde@gmail.com>,
Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] usb: check RNDIS buffer offsets & length
Date: Wed, 17 Feb 2016 00:30:26 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1602170027280.17388@wniryva> (raw)
In-Reply-To: <1455633230.7504.107.camel@redhat.com>
Hello Gerd,
+-- On Tue, 16 Feb 2016, Gerd Hoffmann wrote --+
| Moves up the check so it is done for every control xfer. Good.
...
| Why this is needed? All control transfers go through do_token_setup
| first, so with the check moved in do_token_setup we should never ever
| trigger it here ...
I see, okay.
| > - if (bufoffs + buflen > length)
| > + if (buflen > length || bufoffs >= length || bufoffs + buflen > length) {
| > return USB_RET_STALL;
| > + }
|
| What is this? Not mentioned in the commit message. Looks like integer
| overflow prevention to me (if correct: separate patch with proper commit
| message please).
That's right. I've sent separate revised patches for the above two changes.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-02-16 19:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-05 10:54 [Qemu-devel] [PATCH] usb: check RNDIS buffer offsets & length P J P
2016-02-09 11:01 ` P J P
2016-02-15 4:26 ` P J P
2016-02-15 9:41 ` Gerd Hoffmann
2016-02-16 14:33 ` Gerd Hoffmann
2016-02-16 19:00 ` P J P [this message]
2016-02-17 8:25 ` P J P
2016-02-17 14:46 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602170027280.17388@wniryva \
--to=ppandit@redhat.com \
--cc=kraxel@redhat.com \
--cc=luodalongde@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).