From: P J P <ppandit@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>,
Liu Ling <liuling-it@360.cn>
Subject: Re: [Qemu-devel] [PATCH] net: check packet payload length
Date: Thu, 18 Feb 2016 00:20:36 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1602172316050.17380@wniryva> (raw)
In-Reply-To: <878u2jh4uz.fsf@blackfin.pond.sub.org>
+-- On Wed, 17 Feb 2016, Markus Armbruster wrote --+
| Is calling this function with a partial IPv4 TCP/UDP packet legitimate?
| If partial packet is okay, what about a partial header?
Partial? That shouldn't harm I guess.
| If not, should we assert plen + hlen <= length? Or == length, even?
The proposed patch would handle that, no? Ie return if it's >= length.
Couple of places they check to ensure that length is > minimum packet length.
| If either is legit, are the callers that can do it prepared for the
| checksum not to be computed?
IIUC checksum is not always computed, only if it's requested.
| Style nitpick: we generally omit obviously superfluous parenthesis.
Okay. Should I resend it?
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-02-17 18:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 12:08 [Qemu-devel] [PATCH] net: check packet payload length P J P
2016-02-17 12:57 ` Markus Armbruster
2016-02-17 18:50 ` P J P [this message]
2016-02-18 7:42 ` P J P
2016-02-18 9:31 ` Markus Armbruster
2016-02-18 10:33 ` P J P
2016-02-23 7:57 ` Jason Wang
2016-02-23 11:11 ` P J P
2016-02-24 3:03 ` Jason Wang
2016-02-24 4:37 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602172316050.17380@wniryva \
--to=ppandit@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=liuling-it@360.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).