From: P J P <ppandit@redhat.com>
To: Eric Blake <eblake@redhat.com>
Cc: Jason Wang <jasowang@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net: minor indentation updates
Date: Thu, 18 Feb 2016 00:24:37 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1602180021160.17380@wniryva> (raw)
In-Reply-To: <56C479EC.3090802@redhat.com>
+-- On Wed, 17 Feb 2016, Eric Blake wrote --+
| Cleaning up existing code is best done as part of a series that is
| otherwise touching the code; doing it in isolation makes 'git blame'
| attribute the wrong author for no good reason.
Ah, okay. I noticed it while patching 'net_checksum_calculate' routine.
Should have sent both together.
| If we DO decide the touch-up is worth it, please add spaces around the
| binary + as part of the cleanup.
Okay.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-02-17 18:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 12:35 [Qemu-devel] [PATCH] net: minor indentation updates P J P
2016-02-17 13:47 ` Eric Blake
2016-02-17 18:54 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602180021160.17380@wniryva \
--to=ppandit@redhat.com \
--cc=eblake@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).