From: P J P <ppandit@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Markus Armbruster <armbru@redhat.com>,
Liu Ling <liuling-it@360.cn>
Subject: Re: [Qemu-devel] [PATCH] net: check packet payload length
Date: Wed, 24 Feb 2016 10:07:54 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1602241003590.1508@wniryva> (raw)
In-Reply-To: <56CD1D93.2010708@redhat.com>
+-- On Wed, 24 Feb 2016, Jason Wang wrote --+
| > - hw/net/virtio-net.c
| > if (size > 27 && size < 1500) &&
| > (buf[34] == 0 && buf[35] == 67)) {
|
| Are we sure size of buf is >= 35 here?
No; I'm yet to see why it checks for > 27. If (27 < size < 34) then we have
another OOB access there.
| > + if (len < 14+20)
| > + return;
|
| Ok.
I have sent a revised v2 of this patch.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-02-24 4:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 12:08 [Qemu-devel] [PATCH] net: check packet payload length P J P
2016-02-17 12:57 ` Markus Armbruster
2016-02-17 18:50 ` P J P
2016-02-18 7:42 ` P J P
2016-02-18 9:31 ` Markus Armbruster
2016-02-18 10:33 ` P J P
2016-02-23 7:57 ` Jason Wang
2016-02-23 11:11 ` P J P
2016-02-24 3:03 ` Jason Wang
2016-02-24 4:37 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602241003590.1508@wniryva \
--to=ppandit@redhat.com \
--cc=armbru@redhat.com \
--cc=jasowang@redhat.com \
--cc=liuling-it@360.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).