From: P J P <ppandit@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: Yang Hongke <yanghongke@huawei.com>,
QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers
Date: Wed, 24 Feb 2016 11:28:15 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1602241115410.5456@wniryva> (raw)
In-Reply-To: <56CD0CDA.9050709@redhat.com>
+-- On Wed, 24 Feb 2016, Jason Wang wrote --+
| Right, but since setting STARTPG,STOPPG,BOUNDARY and CURPAG is not
| atomic. Try to limit it during value setting is hard to be correct.
I see.
| Then let's return true when s->stop <= s->start?
Okay. Though I'm not sure if it's the right place for it, because more than
buffer is full, it says buffer does not exist.
| It's really hard to say there's no such driver. Which means if there's
| such a driver and it works on real hardware, we need make it work for qemu.
I guess better would be to see if the hardware standard specifies such an
interface for the driver. I did not find it mentioned anywhere; Even kernel
drivers have it fixed.
I'll send a revised patch for ne2000_buffer_full().
--
- P J P
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-02-24 5:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 14:29 [Qemu-devel] [PATCH] net: ne2000: check ring buffer control registers P J P
2016-02-05 9:04 ` Jason Wang
2016-02-05 9:29 ` [Qemu-devel] 答复: " yanghongke
2016-02-09 6:49 ` P J P
2016-02-09 6:47 ` [Qemu-devel] " P J P
2016-02-15 4:25 ` P J P
2016-02-23 3:27 ` Jason Wang
2016-02-23 8:28 ` P J P
2016-02-24 1:52 ` Jason Wang
2016-02-24 5:58 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1602241115410.5456@wniryva \
--to=ppandit@redhat.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yanghongke@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).