From: P J P <ppandit@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Paolo Bonzini <pbonzini@redhat.com>,
Huawei PSIRT <PSIRT@huawei.com>
Subject: Re: [Qemu-devel] [PATCH] scsi: esp: check TI buffer index before read/write
Date: Tue, 31 May 2016 17:08:18 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1605311558040.21406@wniryva> (raw)
In-Reply-To: <CAFEAcA-pJPdpRfc8kg4WxkJm9Y-dWwcMBCQseXMG0AiqpK0hGA@mail.gmail.com>
+-- On Tue, 31 May 2016, Peter Maydell wrote --+
| This is a FIFO *read*, and the trace message is for the case when the FIFO
| is too full, which can't happen for a read.
Okay.
| OK, so we need to fix these code paths so that they keep all of the read,
| write and size values in sync (or just rewrite the code so it isn't tracking
| three values, since two out of three should determine the other.
I've sent a revised patch v2.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-05-31 11:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 18:58 [Qemu-devel] [PATCH] scsi: esp: check TI buffer index before read/write P J P
2016-05-30 20:06 ` Peter Maydell
2016-05-31 5:20 ` P J P
2016-05-31 7:58 ` Peter Maydell
2016-05-31 11:38 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1605311558040.21406@wniryva \
--to=ppandit@redhat.com \
--cc=PSIRT@huawei.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).