From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50052)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bh0sF-0007HO-Aa
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 16:52:12 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bh0sC-00077d-7f
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 16:52:11 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34014)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bh0sC-00077Z-0h
	for qemu-devel@nongnu.org; Mon, 05 Sep 2016 16:52:08 -0400
Date: Tue, 6 Sep 2016 02:22:00 +0530 (IST)
From: P J P <ppandit@redhat.com>
In-Reply-To: <d115ae37-d7fe-4351-f802-5dec1c23422b@redhat.com>
Message-ID: <alpine.LFD.2.20.1609060220580.20983@wniryva>
References: <1472884428-9975-1-git-send-email-ppandit@redhat.com>
	<fe88297e-34a1-a51c-b964-062f31c20b14@redhat.com>
	<alpine.LFD.2.20.1609051450510.15083@wniryva>
	<ea703469-dc33-d1f5-3221-8d0f67bde362@redhat.com>
	<alpine.LFD.2.20.1609051600210.15714@wniryva>
	<c1eca7af-a918-8938-6d7e-dacf74e35c80@redhat.com>
	<alpine.LFD.2.20.1609051824140.16376@wniryva>
	<d115ae37-d7fe-4351-f802-5dec1c23422b@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH] scsi: pvscsi: request descriptor
 data_length to 32 bit
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>, Dmitry Fleytman <dmitry@daynix.com>, Li Qiang <liqiang6-s@360.cn>

+-- On Mon, 5 Sep 2016, Paolo Bonzini wrote --+
| chunk_size should be uint32_t.
| 
| > -    while (data_length) {
| > -        while (!sg.resid) {
| > +    while (data_length && n < 2048) {
| > +        while (!sg.resid && n++ < 2048) {
| >              pvscsi_get_next_sg_elem(&sg);
| > -        assert(data_length > 0);
| > -        chunk_size = MIN((unsigned) data_length, sg.resid);
| > +        chunk_size = MIN(data_length, sg.resid);
| > Does this look okay?
| 
| Yes, just change 2048 to a #define PVSCSI_MAX_SG_ELEM.

  Done. I've sent a revised patch v2.

Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F