From: P J P <ppandit@redhat.com>
To: Dmitry Fleytman <dmitry@daynix.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Qemu Developers <qemu-devel@nongnu.org>,
Li Qiang <liqiang6-s@360.cn>
Subject: Re: [Qemu-devel] [PATCH v3] scsi: pvscsi: avoid infinite loop while building SG list
Date: Tue, 13 Sep 2016 18:23:12 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1609131804380.31207@wniryva> (raw)
In-Reply-To: <8E89EAFA-7D8A-4108-9EBD-B9BE9E5C87F5@daynix.com>
Hello Dmitry,
+-- On Tue, 13 Sep 2016, Dmitry Fleytman wrote --+
| It should be in the same patch because otherwise a broken logic will be
| introduced.
Not even same patch-set?
| pvscsi_build_sglist() must perform all rollback actions required to handle
| the error cleanly. Please also note that pvscsi_build_sglist() caller(s)
| should be aware of SG list creation failure and handle this error scenario
| accordingly.
I see. All callers leading up to 'pvscsi_convert_sglist' appear to be
returning void.
MemoryRegionOps pvscsi_ops = {
.write = pvscsi_io_write
-> pvscsi_io_write
-> pvscsi_process_io
->pvscsi_process_request_descriptor
-> pvscsi_build_sglist
-> pvscsi_convert_sglist
This looks to be a big patch to fix an infinite loop issue. It'll help to
separate the two patches, no?
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-09-13 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-06 17:53 [Qemu-devel] [PATCH v3] scsi: pvscsi: avoid infinite loop while building SG list P J P
2016-09-13 7:01 ` P J P
2016-09-13 8:54 ` Dmitry Fleytman
2016-09-13 11:20 ` P J P
2016-09-13 12:00 ` Dmitry Fleytman
2016-09-13 12:53 ` P J P [this message]
2016-09-13 13:05 ` Dmitry Fleytman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1609131804380.31207@wniryva \
--to=ppandit@redhat.com \
--cc=dmitry@daynix.com \
--cc=liqiang6-s@360.cn \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).