From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bluYX-0006zV-Ns for qemu-devel@nongnu.org; Mon, 19 Sep 2016 05:08:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bluYR-0003Qm-WF for qemu-devel@nongnu.org; Mon, 19 Sep 2016 05:08:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60194) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bluYR-0003Qg-QI for qemu-devel@nongnu.org; Mon, 19 Sep 2016 05:07:59 -0400 Date: Mon, 19 Sep 2016 14:37:48 +0530 (IST) From: P J P In-Reply-To: Message-ID: References: <1473939282-3596-1-git-send-email-ppandit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH] virtio: add check for descriptor's mapped address List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laszlo Ersek Cc: Qemu Developers , Qinghao Tang , Stefan Hajnoczi , "Michael S. Tsirkin" +-- On Fri, 16 Sep 2016, Laszlo Ersek wrote --+ | CC Stefan | I think it would be reasonable to handle this other guest bug similarly: | | if (iov[num_sg].iov_base == NULL) { | error_report("virtio: bogus descriptor or out of resources"); | exit(EXIT_FAILURE); | } ... | So, unless Stefan or someone else has a better idea, I suggest the above | error message, and exit(EXIT_FAILURE). I have sent a revised patch v2. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F