From: P J P <ppandit@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>, Li Qiang <liqiang6-s@360.cn>
Subject: Re: [Qemu-devel] [PATCH] usb: xHCI: add check to limit command TRB processing
Date: Fri, 7 Oct 2016 17:10:14 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1610071500200.1956@wniryva> (raw)
In-Reply-To: <1475828544.13132.16.camel@redhat.com>
Hello Gerd,
+-- On Fri, 7 Oct 2016, Gerd Hoffmann wrote --+
| I think it is better to apply the limit to link trbs only (which allow
| to jump to another address so the guest can build loops with it). Also
| I think the limit can be much stricter then without breaking stuff as
| typically a link trb is used at the end of a page full of normal trbs,
| to jump to the next page with trbs.
Okay.
| both xhci_ring_fetch and xhci_ring_chain_length, so we should fix both.
| Is there a reproducer? If so, can you try the attached patch with it?
Yes, the attached patch does fix this issue.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
prev parent reply other threads:[~2016-10-07 11:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 5:50 [Qemu-devel] [PATCH] usb: xHCI: add check to limit command TRB processing P J P
2016-10-07 8:22 ` Gerd Hoffmann
2016-10-07 11:40 ` P J P [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1610071500200.1956@wniryva \
--to=ppandit@redhat.com \
--cc=kraxel@redhat.com \
--cc=liqiang6-s@360.cn \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).