From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43805)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1byban-00079O-C9
	for qemu-devel@nongnu.org; Mon, 24 Oct 2016 05:30:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <ppandit@redhat.com>) id 1bybai-0006yL-Fa
	for qemu-devel@nongnu.org; Mon, 24 Oct 2016 05:30:53 -0400
Date: Mon, 24 Oct 2016 15:00:42 +0530 (IST)
From: P J P <ppandit@redhat.com>
In-Reply-To: <7b491ddb-495a-1a85-fd67-2ccb7752891e@redhat.com>
Message-ID: <alpine.LFD.2.20.1610241451100.5077@wniryva>
References: <1477051769-4891-1-git-send-email-ppandit@redhat.com>
	<7b491ddb-495a-1a85-fd67-2ccb7752891e@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Subject: Re: [Qemu-devel] [PATCH] net: rtl8139: limit processing of ring
 descriptors
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jason Wang <jasowang@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>, Andrew Henderson <hendersa@icculus.org>, qemu-stable@nongnu.org

  Hello Jason,

+-- On Mon, 24 Oct 2016, Jason Wang wrote --+
| > RTL8139 ethernet controller in C+ mode supports multiple
| > descriptor rings, each with maximum of 64 descriptors. While
| > processing transmit descriptor ring in 'rtl8139_cplus_transmit',
| > it does not limit the descriptor count and runs forever.
| >
| > diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
| > index 3345bc6..f05e59c 100644
| > --- a/hw/net/rtl8139.c
| > +++ b/hw/net/rtl8139.c
| > @@ -2350,7 +2350,7 @@ static void rtl8139_cplus_transmit(RTL8139State *s)
| >   {
| >       int txcount = 0;
| >   -    while (rtl8139_cplus_transmit_one(s))
| > +    while (txcount < 64 && rtl8139_cplus_transmit_one(s))
| >       {
| >           ++txcount;
| >       }
| 
| Applied to -net, thanks.

  Thank you. CC'ing '-stable' as it affects older versions too; Was introduced 
in commit

  -> git.qemu.org/?p=qemu.git;a=commit;h=49ab747f668f421138d5b40d83fa279c4


Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F