From: P J P <ppandit@redhat.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Prasad J Pandit <pjp@fedoraproject.org>,
qemu-arm <qemu-arm@nongnu.org>,
"Edgar E . Iglesias" <edgar.iglesias@gmail.com>,
Huawei PSIRT <psirt@huawei.com>
Subject: Re: [Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values
Date: Thu, 27 Oct 2016 11:59:36 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1610271156591.14744@wniryva> (raw)
In-Reply-To: <CAKmqyKOuX7cZuYa7xCc69b322S3XpM_0VQMc0DQ4b=Gvq3UM+w@mail.gmail.com>
+-- On Wed, 26 Oct 2016, Alistair Francis wrote --+
| > * Device model for Cadence UART
| > + * -> http://www.xilinx.com/support/documentation/user_guides/ug585-Zynq-7000-TRM.pdf
|
| Nit pick, I would put the URL under the title below.
Okay.
| > + case R_BRGR: /* Baud rate generator */
| > + s->r[offset] = 0x028B; /* default reset value */
|
| Why do we still have the reset value here, I thought we were just
| ignoring the invalid writes? You don't need to reset it.
Wouldn't that leave the registers undefined ?
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-10-27 6:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 21:22 [Qemu-devel] [PATCH v3] char: cadence: check baud rate generator and divider values P J P
2016-10-26 21:45 ` Alistair Francis
2016-10-27 6:29 ` P J P [this message]
2016-10-27 19:02 ` Alistair Francis
2016-10-27 20:12 ` P J P
2016-10-26 22:37 ` Peter Maydell
2016-10-27 6:35 ` P J P
2016-10-27 19:03 ` Alistair Francis
2016-10-27 19:13 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1610271156591.14744@wniryva \
--to=ppandit@redhat.com \
--cc=alistair.francis@xilinx.com \
--cc=edgar.iglesias@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=pjp@fedoraproject.org \
--cc=psirt@huawei.com \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).