From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38633) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6gpI-0001wJ-92 for qemu-devel@nongnu.org; Tue, 15 Nov 2016 11:43:17 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6gpE-0008TJ-DB for qemu-devel@nongnu.org; Tue, 15 Nov 2016 11:43:16 -0500 Received: from mx1.redhat.com ([209.132.183.28]:49096) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1c6gpE-0008Sm-7h for qemu-devel@nongnu.org; Tue, 15 Nov 2016 11:43:12 -0500 Date: Tue, 15 Nov 2016 22:13:05 +0530 (IST) From: P J P In-Reply-To: <1476776717-24807-1-git-send-email-ppandit@redhat.com> Message-ID: References: <1476776717-24807-1-git-send-email-ppandit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH] display: cirrus: check vga bits per pixel(bpp) value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Peter Maydell , Huawei PSIRT +-- On Tue, 18 Oct 2016, P J P wrote --+ | From: Prasad J Pandit | | In Cirrus CLGD 54xx VGA Emulator, if cirrus graphics mode is VGA, | 'cirrus_get_bpp' returns zero(0), which could lead to a divide | by zero error in while copying pixel data. The same could occur | via blit pitch values. Add check to avoid it. | | Reported-by: Huawei PSIRT | Signed-off-by: Prasad J Pandit | --- | hw/display/cirrus_vga.c | 14 ++++++++++---- | 1 file changed, 10 insertions(+), 4 deletions(-) | Ping...! -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F