From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47758) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cDqwN-00028z-CO for qemu-devel@nongnu.org; Mon, 05 Dec 2016 05:56:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cDqwK-0007Bu-AE for qemu-devel@nongnu.org; Mon, 05 Dec 2016 05:56:11 -0500 Received: from mx1.redhat.com ([209.132.183.28]:47068) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cDqwK-0007Bn-4B for qemu-devel@nongnu.org; Mon, 05 Dec 2016 05:56:08 -0500 Date: Mon, 5 Dec 2016 16:00:46 +0530 (IST) From: P J P In-Reply-To: Message-ID: References: <1480678088-21464-1-git-send-email-ppandit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH] net: virtio-net: initialise local 'netcfg' variable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jason Wang Cc: Azureyang , Qemu Developers Hello Jason, +-- On Mon, 5 Dec 2016, Jason Wang wrote --+ | See feature_sizes[] in virtio-net.c, we won't expose mtu to guest until MTU | feature were negotiated. Oh, it updates config size without the 'mtu' field during realise, okay. Still IMO having an initialiser({}) is better. But upto you. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F