From: P J P <ppandit@redhat.com>
To: Pankaj Gupta <pagupta@redhat.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Zhenhao Hong <zhenhaohong@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size
Date: Tue, 13 Dec 2016 17:03:15 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1612131700340.6298@wniryva> (raw)
In-Reply-To: <995759159.4566665.1481626321833.JavaMail.zimbra@redhat.com>
+-- On Tue, 13 Dec 2016, Pankaj Gupta wrote --+
| > + if (max_size) {
| > + resp->hdr.type = VIRTIO_GPU_RESP_OK_CAPSET;
| > + virgl_renderer_fill_caps(gc.capset_id,
| > + gc.capset_version,
| > + (void *)resp->capset_data);
| > + }
| > virtio_gpu_ctrl_response(g, cmd, &resp->hdr, sizeof(*resp) + max_size);
|
| Just one point here for 'max_size=0', do we don't require to set resp->hdr.type?
I thought hdr.type is if capabilities data is set.
| If yes, other patch on list by 'Li Qiang' can also help to avoid sending garbage value.
g_malloc0 one? Yes.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-12-13 11:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-13 7:14 [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size P J P
2016-12-13 10:52 ` Pankaj Gupta
2016-12-13 11:33 ` P J P [this message]
2016-12-13 11:17 ` Gerd Hoffmann
2016-12-13 11:50 ` P J P
2016-12-13 12:07 ` Gerd Hoffmann
2016-12-13 14:26 ` P J P
2016-12-13 16:01 ` Marc-André Lureau
2016-12-14 7:03 ` P J P
-- strict thread matches above, loose matches on Subject: below --
2016-12-14 7:01 P J P
2016-12-20 11:04 ` P J P
2016-12-20 14:36 ` Gerd Hoffmann
2016-12-20 11:08 ` Marc-André Lureau
2016-12-20 11:56 ` P J P
2016-12-20 13:52 ` Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1612131700340.6298@wniryva \
--to=ppandit@redhat.com \
--cc=kraxel@redhat.com \
--cc=pagupta@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenhaohong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).