From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39570) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cH3b3-0004RE-K3 for qemu-devel@nongnu.org; Wed, 14 Dec 2016 02:03:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cH3az-0003nb-LK for qemu-devel@nongnu.org; Wed, 14 Dec 2016 02:03:25 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54102) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cH3az-0003nW-GJ for qemu-devel@nongnu.org; Wed, 14 Dec 2016 02:03:21 -0500 Date: Wed, 14 Dec 2016 12:33:15 +0530 (IST) From: P J P In-Reply-To: Message-ID: References: <20161213071439.32322-1-ppandit@redhat.com> <1481627861.27088.116.camel@redhat.com> <1481630872.27088.128.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?ISO-8859-15?Q?Marc-Andr=E9_Lureau?= Cc: Gerd Hoffmann , Zhenhao Hong , Qemu Developers +-- On Tue, 13 Dec 2016, Marc-Andr=C3=A9 Lureau wrote --+ | > - resp =3D g_malloc(sizeof(*resp) + max_size); | > + if (!max_size) { | > + cmd->error =3D VIRTIO_GPU_RESP_ERR_INVALID_PARAMETER; | > + return; | > + } | > | > + resp =3D g_malloc(sizeof(*resp) + max_size); | > resp->hdr.type =3D VIRTIO_GPU_RESP_OK_CAPSET; | | That looks good to me, waiting for the proper patch. Okay, sent. Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F