From: P J P <ppandit@redhat.com>
To: "Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Zhenhao Hong <zhenhaohong@gmail.com>,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size
Date: Tue, 20 Dec 2016 17:26:16 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1612201723570.28755@wniryva> (raw)
In-Reply-To: <CAJ+F1CJq2tp+-sDjX6EqZ7mFx63uUkc3=i8yaQyVmmG1c1RTNw@mail.gmail.com>
Hello Marc,
+-- On Tue, 20 Dec 2016, Marc-André Lureau wrote --+
| > + if (!max_size) {
|
| Shouldn't it check for >= sizeof(union virgl_caps) ? (since that's what
| virglrenderer vrend_renderer_fill_caps() expects)
No, 'max_size' isn't set by a user, it's set by the library function
'vrend_renderer_get_cap_set'.
-> https://cgit.freedesktop.org/~airlied/virglrenderer/tree/src/vrend_renderer.c#n6280
And if not zero, it'll be set to sizeof(union virgl_caps).
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2016-12-20 11:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 7:01 [Qemu-devel] [PATCH] display: virtio-gpu-3d: check virgl capabilities max_size P J P
2016-12-20 11:04 ` P J P
2016-12-20 14:36 ` Gerd Hoffmann
2016-12-20 11:08 ` Marc-André Lureau
2016-12-20 11:56 ` P J P [this message]
2016-12-20 13:52 ` Marc-André Lureau
-- strict thread matches above, loose matches on Subject: below --
2016-12-13 7:14 P J P
2016-12-13 10:52 ` Pankaj Gupta
2016-12-13 11:33 ` P J P
2016-12-13 11:17 ` Gerd Hoffmann
2016-12-13 11:50 ` P J P
2016-12-13 12:07 ` Gerd Hoffmann
2016-12-13 14:26 ` P J P
2016-12-13 16:01 ` Marc-André Lureau
2016-12-14 7:03 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1612201723570.28755@wniryva \
--to=ppandit@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=zhenhaohong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).