From: P J P <ppandit@redhat.com>
To: Alistair Francis <alistair23@gmail.com>
Cc: Qemu Developers <qemu-devel@nongnu.org>,
Peter Maydell <peter.maydell@linaro.org>,
Wjjzhang <wjjzhang@tencent.com>, Jiang Xin <jiangxin1@huawei.com>
Subject: Re: [Qemu-devel] [PATCH 1/2] sd: sdhci: check transfer mode register in multi block transfer
Date: Wed, 8 Feb 2017 10:47:08 +0530 (IST) [thread overview]
Message-ID: <alpine.LFD.2.20.1702081040410.17258@wniryva> (raw)
In-Reply-To: <CAKmqyKNerMUco=iokdcWLMu14mFRvxkO81VV=JfqfHOOD_CVfQ@mail.gmail.com>
Hello Alistair,
+-- On Tue, 7 Feb 2017, Alistair Francis wrote --+
| As it doesn't look like we have ever supported an infinite transfer
| and we don't want infinite loops occurring I think we should add an
| unsupported print statement here saying that we don't support infinite
| transfers and then I'm ok with this patch.
Okay, will do.
| > - MASKED_WRITE(s->trnmod, mask, value);
| > + MASKED_WRITE(s->trnmod, mask, value & 0x0037);
|
| What is this change doing?
It is possible to set 's->trnmod' to an invalid value(> 6 bits). Above
mask(0x0037) would limit 'value' to the 6 bits mentioned in the spec.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F
next prev parent reply other threads:[~2017-02-08 5:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 12:24 [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage P J P
2017-01-31 12:24 ` [Qemu-devel] [PATCH 1/2] sd: sdhci: check transfer mode register in multi block transfer P J P
2017-02-07 23:12 ` Alistair Francis
2017-02-08 5:17 ` P J P [this message]
2017-01-31 12:24 ` [Qemu-devel] [PATCH 2/2] sd: sdhci: block count enable not relevant in single " P J P
2017-02-07 23:15 ` Alistair Francis
2017-02-06 7:55 ` [Qemu-devel] [PATCH 0/2] sd: sdhci: correct transfer mode register usage P J P
2017-02-07 17:29 ` Peter Maydell
2017-02-07 19:12 ` P J P
2017-02-07 21:57 ` Alistair Francis
2017-02-08 5:06 ` P J P
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.20.1702081040410.17258@wniryva \
--to=ppandit@redhat.com \
--cc=alistair23@gmail.com \
--cc=jiangxin1@huawei.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=wjjzhang@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).