From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59024) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cdrfW-0000bv-D2 for qemu-devel@nongnu.org; Tue, 14 Feb 2017 23:58:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cdrfS-0005Ni-MS for qemu-devel@nongnu.org; Tue, 14 Feb 2017 23:58:18 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51068) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cdrfS-0005Ml-GR for qemu-devel@nongnu.org; Tue, 14 Feb 2017 23:58:14 -0500 Date: Wed, 15 Feb 2017 10:28:06 +0530 (IST) From: P J P In-Reply-To: Message-ID: References: <20170214185225.7994-1-ppandit@redhat.com> <20170214185225.7994-3-ppandit@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Subject: Re: [Qemu-devel] [PATCH v4 2/4] sd: sdhci: check transfer mode register in multi block transfer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: Qemu Developers , Peter Maydell , Wjjzhang , Jiang Xin Hello Alistair, +-- On Tue, 14 Feb 2017, Alistair Francis wrote --+ | On Tue, Feb 14, 2017 at 10:52 AM, P J P wrote: | > From: Prasad J Pandit | > | > In the SDHCI protocol, the transfer mode register value | > is used during multi block transfer to check if block count | > register is enabled and should be updated. Transfer mode | > register could be set such that, block count register would | > not be updated, thus leading to an infinite loop. Add check | > to avoid it. | > | > Reported-by: Wjjzhang | > Reported-by: Jiang Xin | > Signed-off-by: Prasad J Pandit | | Didn't I already review this? Yes, you did. I resent it owing to thread -> https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg02898.html Thank you. -- Prasad J Pandit / Red Hat Product Security Team 47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F