From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: Aleksandar Markovic <amarkovic@wavecomp.com>
Cc: "Fredrik Noring" <noring@nocrew.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Jürgen Urban" <JuergenUrban@gmx.de>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes
Date: Fri, 9 Nov 2018 16:49:29 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.1811091634470.27920@eddie.linux-mips.org> (raw)
In-Reply-To: <BN6PR2201MB1251A570A76178D7BD66B247C6C60@BN6PR2201MB1251.namprd22.prod.outlook.com>
On Fri, 9 Nov 2018, Aleksandar Markovic wrote:
> > > I think that the best solution that you exclude DDIV, DDIVU, DMULT, DMULTU
> > > in a separate patch - there is no document to support their inclusion.
> >
> > As Maciej noted, the 64-bit MIPS Linux psABI is indivisible, so how could
> > your alternative possibly work?
>
> Since we are rapidly approaching 3.1 release, we don't have time for
> prolonged discussions - so please provide the patch that removes
> emulation of these instructions that don't belong to R5900 set, and, if
> you find a justification document later on, they can be reintroduced in
> 3.1+ timeframe.
You know well enough that nobody was bothered over the years to actually
document the 64-bit MIPS Linux psABI (there is the 64-bit ELF document
from SGI, relevant for IRIX, which has been partially implemented by
Linux) and even when it comes to the 32-bit psABI the only document is
from SGI from mid 1990s, that has several errors and surely was not
written with Linux in mind (and FWIW not entirely with IRIX either).
The psABI has been set by the architecture back in 1991 and what Linux
has implemented on top of that around 2001, along with common sense. You
can't question what was done 17 years ago asking for a backing piece of
paper (possibly virtual). You can put anything on paper and if it does
not match reality, then it is irrelevant.
If you question what I state, then ask the MIPS/Linux kernel developers
at the relevant mailing list, i.e. <linux-mips@linux-mips.org>.
Maciej
next prev parent reply other threads:[~2018-11-09 16:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-07 19:17 [Qemu-devel] [PATCH v2 0/6] Fix decoding mechanisms of the R5900 Fredrik Noring
2018-11-07 19:18 ` [Qemu-devel] [PATCH v2 1/6] target/mips: Fix decoding mechanism of R5900 MFLO1, MFHI1, MTLO1 and MTHI1 Fredrik Noring
2018-11-17 15:28 ` Aleksandar Markovic
2018-11-07 19:18 ` [Qemu-devel] [PATCH v2 2/6] target/mips: Fix decoding mechanism of R5900 DIV1 and DIVU1 Fredrik Noring
2018-11-07 19:18 ` [Qemu-devel] [PATCH v2 3/6] target/mips: Fix HI[ac] and LO[ac] 32-bit truncation with MIPS64 DSP ASE Fredrik Noring
2018-11-08 10:17 ` Aleksandar Markovic
2018-11-07 19:19 ` [Qemu-devel] [PATCH v2 4/6] target/mips: Fix decoding mechanism of special R5900 opcodes Fredrik Noring
2018-11-08 10:27 ` Aleksandar Markovic
2018-11-08 18:50 ` Fredrik Noring
2018-11-08 22:00 ` Maciej W. Rozycki
2018-11-09 9:50 ` Aleksandar Markovic
2018-11-09 13:24 ` Fredrik Noring
2018-11-09 14:23 ` Aleksandar Markovic
2018-11-09 14:35 ` Fredrik Noring
2018-11-09 14:37 ` Aleksandar Markovic
2018-11-09 15:23 ` Aleksandar Markovic
2018-11-09 16:49 ` Maciej W. Rozycki [this message]
2018-11-09 13:53 ` Maciej W. Rozycki
2018-11-17 15:25 ` Aleksandar Markovic
2018-11-07 19:19 ` [Qemu-devel] [PATCH v2 5/6] target/mips: Guard check_insn_opc_user_only with INSN_R5900 check Fredrik Noring
2018-11-17 15:27 ` Aleksandar Markovic
2018-11-07 19:19 ` [Qemu-devel] [PATCH v2 6/6] target/mips: Guard check_insn " Fredrik Noring
2018-11-17 15:26 ` Aleksandar Markovic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.1811091634470.27920@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=JuergenUrban@gmx.de \
--cc=amarkovic@wavecomp.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=noring@nocrew.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).