From: "Maciej W. Rozycki" <macro@linux-mips.org>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
Cc: Aleksandar Rikalo <aleksandar.rikalo@syrmia.com>,
Richard Henderson <richard.henderson@linaro.org>,
"qemu-devel@nongnu.org Developers" <qemu-devel@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [PATCH-for-5.2?] target/mips/translate: Check R6 reserved encoding for Load Linked Word
Date: Tue, 8 Dec 2020 18:43:22 +0000 (GMT) [thread overview]
Message-ID: <alpine.LFD.2.21.2012081838061.2104409@eddie.linux-mips.org> (raw)
In-Reply-To: <CAAdtpL7zG6Ocbv0ChjQUArGkmTEegzC5AW5O3DjiDxFK7oEMWg@mail.gmail.com>
On Tue, 8 Dec 2020, Philippe Mathieu-Daudé wrote:
> Duh I hit that again, read the patch again, looks correct. I guess
> I got confused myself reviewing the offending patch...
> So I'm applying this patch to mips-next queue, using
> Fixes: d9224450208 ("target-mips: Tighten ISA level checks")
What's wrong with current code? What I can see is:
case OPC_LL: /* Load and stores */
check_insn(ctx, ISA_MIPS2);
if (ctx->insn_flags & INSN_R5900) {
check_insn_opc_user_only(ctx, INSN_R5900);
}
/* Fallthrough */
case OPC_LWL:
case OPC_LWR:
check_insn_opc_removed(ctx, ISA_MIPS32R6);
/* Fallthrough */
case OPC_LB:
case OPC_LH:
case OPC_LW:
case OPC_LWPC:
case OPC_LBU:
case OPC_LHU:
gen_ld(ctx, op, rt, rs, imm);
break;
which looks absolutely right to me: LL is accepted with MIPS2--MIPS32R5
(including R5900 in user emulation only), LWL/LWR are accepted with
MIPS1--MIPS32R5 and the remaining loads are accepted everywhere. What
else do you need?
Maciej
next prev parent reply other threads:[~2020-12-08 18:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-24 13:45 [PATCH-for-5.2?] target/mips/translate: Check R6 reserved encoding for Load Linked Word Philippe Mathieu-Daudé
2020-11-24 15:59 ` Richard Henderson
2020-11-24 16:15 ` Philippe Mathieu-Daudé
2020-12-08 18:34 ` Philippe Mathieu-Daudé
2020-12-08 18:43 ` Maciej W. Rozycki [this message]
2020-12-08 19:12 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LFD.2.21.2012081838061.2104409@eddie.linux-mips.org \
--to=macro@linux-mips.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=aurelien@aurel32.net \
--cc=f4bug@amsat.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).