From: malc <av1474@comtv.ru>
To: Juergen Lock <nox@jelal.kn-bremen.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation.
Date: Tue, 16 Feb 2010 09:52:50 +0300 (MSK) [thread overview]
Message-ID: <alpine.LNX.2.00.1002160951360.1456@linmac> (raw)
In-Reply-To: <20100215224004.GA29604@triton8.kn-bremen.de>
On Mon, 15 Feb 2010, Juergen Lock wrote:
> On Mon, Feb 15, 2010 at 06:16:07AM +0300, malc wrote:
> > On Sun, 14 Feb 2010, Juergen Lock wrote:
> >
> > > Submitted by: Andreas Tobler <andreast@fgznet.ch>
> > >
> > > Signed-off-by: Juergen Lock <nox@jelal.kn-bremen.de>
> > >
> > > --- a/cache-utils.c
> > > +++ b/cache-utils.c
> > > @@ -57,6 +57,23 @@
> > > }
> > > #endif
> > >
> > > +#if defined(__FreeBSD__) || defined(__FreeBSD_kernel__)
> >
> > __FreeBSD_kernel__ is for something like Debian/kFreeBSD?
>
> Yep, it is. Support for it was added to qemu some time ago so I
> figured I should do the same.
>
Perhaps it would be better to avoid this particular ifdefery and
just go with _CALL_SYSV, can you verify that:
~$ gcc -E -dM -x c /dev/null | grep SYSV
yields
#define _CALL_SYSV 1
on FreeBSD and Debian/kFreeBSD?
--
mailto:av1474@comtv.ru
next prev parent reply other threads:[~2010-02-16 6:53 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-14 20:10 [Qemu-devel] [PATCH 0/3] FreeBSD/ppc host patches Juergen Lock
2010-02-14 20:12 ` [Qemu-devel] [PATCH 1/3] Add FreeBSD/ppc host ppc_init_cacheline_sizes() implementation Juergen Lock
2010-02-15 3:15 ` malc
2010-02-15 22:45 ` Juergen Lock
2010-02-15 3:16 ` malc
2010-02-15 22:40 ` Juergen Lock
2010-02-16 6:52 ` malc [this message]
2010-02-16 17:56 ` Juergen Lock
2010-02-16 19:07 ` malc
2010-02-16 19:50 ` [Qemu-devel] " Paolo Bonzini
2010-02-16 20:34 ` Juergen Lock
2010-02-16 21:19 ` Juergen Lock
2010-02-14 20:12 ` [Qemu-devel] [PATCH 2/3] Add FreeBSD/ppc host ucontext definitions Juergen Lock
2010-02-14 20:13 ` [Qemu-devel] [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions Juergen Lock
2010-02-16 21:14 ` [Qemu-devel] " Juergen Lock
2010-04-06 16:28 ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS, STACK_OFFSET} definitions Andreas Färber
2010-04-06 17:14 ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions malc
2010-04-06 17:19 ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS, STACK_OFFSET} definitions Andreas Färber
2010-04-06 17:44 ` [Qemu-devel] Re: [PATCH 3/3] Add FreeBSD/ppc host TCG_TARGET_CALL_{ALIGN_ARGS,STACK_OFFSET} definitions malc
2010-08-14 18:51 ` [Qemu-devel] [PATCH] TCG: Fix Darwin/ppc calling convention recognition Andreas Färber
2010-08-14 20:41 ` [Qemu-devel] " malc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LNX.2.00.1002160951360.1456@linmac \
--to=av1474@comtv.ru \
--cc=nox@jelal.kn-bremen.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).